From: Oleg Nesterov <oleg@redhat.com>
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [BUG stable, 2.6.32.27] sched: delayed cleanup of user_struct
Date: Mon, 10 Jan 2011 15:08:17 +0100 [thread overview]
Message-ID: <20110110140817.GA31708@redhat.com> (raw)
In-Reply-To: <4D2B113A.2060303@profihost.ag>
On 01/10, Stefan Priebe - Profihost AG wrote:
>
> Main problem - right i can't reproduce it. But the system was crashing
> two times more in the past.
>
> You can find the logs here:
> http://pastebin.com/hNd15E8K
Good. Sadly, I didn't see this trace before...
kernel BUG at kernel/workqueue.c:287!
this matches "INIT_DELAYED_WORK() can corrupt the pending work" I
mentioned.
>> Or. You can revert
>> b00bc0b237055b4c45816325ee14f0bd83e6f590
>> uids: Prevent tear down race
>>
>> 3959214f971417f4162926ac52ad4cd042958caa
>> sched: delayed cleanup of user_struct
> Not sure if it is a good idea to introduce another race again.
Which race? b00bc0b237055b4c45816325ee14f0bd83e6f590 fixes the race, yes.
But this race was introduced by 3959214f971417f4162926ac52ad4cd042958caa.
And afaics the latter commit is optimization...
Anyway, this is up to you, of course.
Oleg.
next prev parent reply other threads:[~2011-01-10 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D2AB8F7.7030506@profihost.ag>
[not found] ` <20110110114913.GA22298@redhat.com>
2011-01-10 12:36 ` [BUG stable, 2.6.32.27] sched: delayed cleanup of user_struct Oleg Nesterov
2011-01-10 12:46 ` Stefan Priebe - Profihost AG
2011-01-10 13:35 ` Oleg Nesterov
2011-01-10 14:01 ` Stefan Priebe - Profihost AG
2011-01-10 14:08 ` Oleg Nesterov [this message]
2011-01-10 14:23 ` Stefan Priebe - Profihost AG
2011-01-10 14:19 ` Oleg Nesterov
2011-01-10 17:07 ` Mike Galbraith
2011-01-10 18:23 ` Greg KH
2011-01-10 18:43 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110140817.GA31708@redhat.com \
--to=oleg@redhat.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.priebe@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox