From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Manoj Iyer <manoj.iyer@canonical.com>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] Quirk to fix suspend/resume on Lenovo Edge 11,13,14,15
Date: Thu, 13 Jan 2011 17:39:21 +0000 [thread overview]
Message-ID: <20110113173921.GA22823@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1101131808450.2678@localhost6.localdomain6>
On Thu, Jan 13, 2011 at 06:10:01PM +0100, Thomas Gleixner wrote:
> On Thu, 13 Jan 2011, Matthew Garrett wrote:
>
> > On Thu, Jan 13, 2011 at 10:02:22AM -0600, Manoj Iyer wrote:
> > > Set acpi_skip_timer_override to force ignoring BIOS
> > > IRQ0 pin2 override. This fixes resume from suspend on
> > > AMD based ThinkPad Edge 11,13,14 and 15.
> >
> > This was originally there because of a quirk in some ati chipsets,
> > coupled with DSDT insanity on HP's part. The Thinkpad Edges seem to be
> > Intel machines, so it's not the same underlying issue. Do we have any
>
> The patch description above talks explictely about AMD based ThinkPad
> Edge. So it might be as well the same underlying problem.
I'm sorry, I misread that completely. The reason for the extra quirk on
the HPs was down to their DSDT setting thermal trip points incorrectly
if the override weren't ignored - it would trigger at boot time, not
after suspend/resume. In theory I think that should be handled by the
chipset-specific quirk code already, with the DMI list as a backup. It
may be that we need to look at the chipset quirk code?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-01-13 17:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 16:02 [PATCH 0/1] Quirk to fix suspend/resume on Lenovo Edge 11,13,14,15 Manoj Iyer
2011-01-13 16:02 ` [PATCH] " Manoj Iyer
2011-01-13 16:46 ` Matthew Garrett
2011-01-13 17:10 ` Thomas Gleixner
2011-01-13 17:22 ` Borislav Petkov
2011-01-13 17:33 ` Manoj Iyer
2011-01-13 17:55 ` Borislav Petkov
2011-01-13 18:11 ` Manoj Iyer
2011-01-13 18:30 ` Borislav Petkov
2011-01-13 18:51 ` Thomas Gleixner
2011-01-13 18:58 ` Matthew Garrett
2011-01-13 19:07 ` Borislav Petkov
2011-01-13 19:13 ` Thomas Gleixner
2011-01-13 19:28 ` Borislav Petkov
2011-01-13 19:41 ` Thomas Gleixner
2011-01-13 20:33 ` Manoj Iyer
2011-01-13 21:12 ` Manoj Iyer
2011-01-13 21:40 ` Thomas Gleixner
2011-01-13 21:48 ` Manoj Iyer
2011-01-13 22:40 ` Thomas Gleixner
2011-01-13 21:09 ` Borislav Petkov
2011-01-13 21:30 ` Thomas Gleixner
2011-01-13 21:48 ` Borislav Petkov
2011-01-13 22:55 ` Thomas Gleixner
2011-01-14 19:55 ` Manoj Iyer
2011-01-14 21:41 ` Borislav Petkov
2011-01-28 17:59 ` Andreas Herrmann
2011-01-31 16:44 ` Manoj Iyer
2011-01-31 17:54 ` Manoj Iyer
2011-01-13 19:11 ` Thomas Gleixner
2011-01-13 18:57 ` Manoj Iyer
2011-01-13 17:39 ` Matthew Garrett [this message]
[not found] ` <AANLkTimk_Y4Q_cxg1SJxZiTT2gT9ywr5UGmsqPqwmeCy@mail.gmail.com>
2011-01-13 17:56 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113173921.GA22823@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manoj.iyer@canonical.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox