From: Andi Kleen <andi@firstfloor.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shawn Bohrer <sbohrer@rgmadvisors.com>
Subject: Re: [PATCH] oprofile: Add support for missing Intel core i7 models
Date: Fri, 14 Jan 2011 01:24:35 +0100 [thread overview]
Message-ID: <20110114002435.GR25713@one.firstfloor.org> (raw)
In-Reply-To: <20110113235503.GY4739@erda.amd.com>
On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
> On 13.01.11 17:38:11, Shawn Bohrer wrote:
> > Added missing core i7 models found in "Intel 64 and IA-32 Architectures
> > Software Developer's Manual Volume 3B: System Programming Guide",
> > Table B-1. Tested with oprofile 0.9.6 on a:
> >
> > model : 44
> > model name : Intel(R) Xeon(R) CPU X5680 @ 3.33GHz
> >
> > Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
>
> Andi,
>
> please ACK.
NACK -- first it's wrong because that's a westmere and westmere
has a different event list. And the new way is to fall back to arch-perfmon
and handle the CPUID in user space. This has been already implemented.
So the fix is to upgrade user space.
-Andi
next prev parent reply other threads:[~2011-01-14 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 22:38 [PATCH] oprofile: Add support for missing Intel core i7 models Shawn Bohrer
2011-01-13 23:55 ` Robert Richter
2011-01-14 0:24 ` Andi Kleen [this message]
2011-01-14 2:29 ` Robert Richter
2011-01-14 15:20 ` Maynard Johnson
2011-01-14 23:43 ` Andi Kleen
2011-01-17 14:52 ` William Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114002435.GR25713@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oprofile-list@lists.sf.net \
--cc=robert.richter@amd.com \
--cc=sbohrer@rgmadvisors.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox