Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Maynard Johnson <maynardj@us.ibm.com>]

On 01/13/2011 8:29 PM, Robert Richter wrote:
> On 13.01.11 19:24:35, Andi Kleen wrote:
>> On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
>>> On 13.01.11 17:38:11, Shawn Bohrer wrote:
>>>> Added missing core i7 models found in "Intel 64 and IA-32 Architectures
>>>> Software Developer's Manual Volume 3B: System Programming Guide",
>>>> Table B-1.  Tested with oprofile 0.9.6 on a:
>>>>
>>>> model      : 44
>>>> model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
>>>>
>>>> Signed-off-by: Shawn Bohrer<sbohrer@rgmadvisors.com>
>>>
>>> Andi,
>>>
>>> please ACK.
>>
>> NACK -- first it's wrong because that's a westmere and westmere
>> has a different event list. And the new way is to fall back to arch-perfmon
>> and handle the CPUID in user space. This has been already implemented.
>> So the fix is to upgrade user space.
>
> Andi,
>
> thanks for looking at this.
>
> Will it be the general way in the future not to add model detection
> for new Intel cpus to kernel code and instead use arch_perfmon? Are
> the user land patches for cpu detection already in the oprofile
> repository? I assume oprofile 0.9.6 is not up-to-date and needs to be
> patched.
Yes, as Andi said above, the processor detection via cpuid has already been 
implemented and accepted to oprofile userspace -- thanks to Will Cohen.

-Maynard
>
> -Robert
>