From: Ingo Molnar <mingo@elte.hu>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"Lu, Hongjiu" <hongjiu.lu@intel.com>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH]x86: make relocatable kernel work with new binutils -resend
Date: Tue, 18 Jan 2011 09:05:54 +0100 [thread overview]
Message-ID: <20110118080554.GB18317@elte.hu> (raw)
In-Reply-To: <1295312269.1949.725.camel@sli10-conroe>
* Shaohua Li <shaohua.li@intel.com> wrote:
> On Mon, 2011-01-17 at 18:17 +0800, Ingo Molnar wrote:
> > * Shaohua Li <shaohua.li@intel.com> wrote:
> >
> > > @@ -142,6 +140,11 @@ SECTIONS
> > > CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
> > >
> > > DATA_DATA
> > > +#ifdef CONFIG_X86_32
> > > + jiffies = jiffies_64;
> > > +#else
> > > + jiffies_64 = jiffies;
> > > +#endif
> >
> > I suspect this needs a comment, as to the unsuspecting reader it looks like black
> > magic :-)
>
> does this one look better?
Yeah, thanks!
Ingo
next prev parent reply other threads:[~2011-01-18 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 2:46 [PATCH]x86: make relocatable kernel work with new binutils -resend Shaohua Li
2011-01-17 10:17 ` Ingo Molnar
2011-01-18 0:57 ` Shaohua Li
2011-01-18 8:05 ` Ingo Molnar [this message]
2011-01-18 8:49 ` [tip:x86/urgent] x86: Make relocatable kernel work with new binutils tip-bot for Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118080554.GB18317@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hongjiu.lu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox