public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Jeff Chua <jeff.chua.linux@gmail.com>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.linux-foundation.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management
Date: Sun, 23 Jan 2011 21:35:32 +0100	[thread overview]
Message-ID: <201101232135.32510.rjw@sisk.pl> (raw)
In-Reply-To: <20110123182037.GH24071@khazad-dum.debian.net>

On Sunday, January 23, 2011, Henrique de Moraes Holschuh wrote:
> On Sat, 22 Jan 2011, Rafael J. Wysocki wrote:
> > > I discovered CONFIG_THINKPAD_ACPI caused suspend-to-disk to hang. I
> > > need the Thinkpad ACPI to control the fan and bluetooth. It looks like
> > > the thinkpad acpi is trying acquire locks while suspending.  Disabling
> > > cmos, light, led and hotkeys makes suspend-to-disk works again.
> > 
> > Well, we should tell the thinkpad_acpi maintainer about that, then (CCed).
> 
> What are the requirements re. mutexes for sleep-to-disk versus sleep-to-ram?

No difference.  Basically, there are two differences between suspend and
hibernation, as far as drivers are concerned:
(1) It's better to use the ->freeze()/->thaw() and ->poweroff()/->restore()
    callbacks for hibernation.
(2) It may be _much_ more difficult to get free memory during hibernation
    (so theoretically attempts to get memory during hibernation are more likely
    to block).

> Did something change in that area that caused the driver to hang?  A pointer
> to the ML threads, documentation, or patchset/git commit with those changes
> would be enough answer, and I will pursue it from there.

I'm not aware of any such changes.

Besides, the problem reported by Jeff seems to be caused by CPU hotplug.

Thanks,
Rafael

  reply	other threads:[~2011-01-23 20:35 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 11:26 [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Rafael J. Wysocki
2011-01-20 11:27 ` [PATCH 1/11] ACPI: Introduce acpi_os_ioremap() Rafael J. Wysocki
2011-01-20 11:28 ` [PATCH 2/11] ACPI / PM: Call suspend_nvs_free() earlier during resume Rafael J. Wysocki
2011-01-20 11:30 ` [PATCH 3/11] ACPI: Fix acpi_os_read_memory() and acpi_os_write_memory() Rafael J. Wysocki
2011-01-20 11:30 ` [PATCH 4/11] ACPI: Do not export functions that are only used in osl.c Rafael J. Wysocki
2011-01-20 11:31 ` [PATCH 5/11] ACPI: Change acpi_ioremap_lock into a mutex Rafael J. Wysocki
2011-01-20 11:32 ` [PATCH 6/11] ACPI: Avoid walking the list of iomaps in osl.c twice in a row Rafael J. Wysocki
2011-01-20 11:33 ` [PATCH 7/11] ACPI: Make acpi_os_map_memory() avoid creating unnecessary mappings Rafael J. Wysocki
2011-01-20 11:34 ` [PATCH 8/11] ACPI: Do not use krefs under a mutex in osl.c Rafael J. Wysocki
2011-01-20 11:35 ` [PATCH 9/11] ACPI: Introduce acpi_os_get_iomem() Rafael J. Wysocki
2011-01-20 11:36 ` [PATCH 10/11] ACPI / PM: Use existing ACPI iomaps for NVS save/restore Rafael J. Wysocki
2011-01-20 11:37 ` [PATCH 11/11] ACPI / PM: Make NVS save/restore code use slightly less memory Rafael J. Wysocki
2011-01-20 16:06 ` [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Jeff Chua
2011-01-20 20:57   ` Rafael J. Wysocki
2011-01-20 21:46     ` Jeff Chua
2011-01-21  0:04       ` Rafael J. Wysocki
2011-01-21  2:51         ` Jeff Chua
2011-01-21 12:01           ` Rafael J. Wysocki
2011-01-21 21:06           ` Rafael J. Wysocki
2011-01-22  5:54             ` Jeff Chua
2011-01-22  5:58               ` Jeff Chua
2011-01-22  9:25                 ` Rafael J. Wysocki
2011-01-22 17:24                   ` Jeff Chua
2011-01-22 19:12                     ` Rafael J. Wysocki
2011-01-23  0:14                       ` Jeff Chua
2011-01-23 20:28                         ` Rafael J. Wysocki
2011-01-24  1:13                           ` Jeff Chua
2011-01-24 21:36                             ` Rafael J. Wysocki
2011-01-22  9:13               ` Rafael J. Wysocki
2011-01-23 18:20                 ` Henrique de Moraes Holschuh
2011-01-23 20:35                   ` Rafael J. Wysocki [this message]
2011-01-23 23:15                     ` Henrique de Moraes Holschuh
2011-01-24 21:37                       ` Rafael J. Wysocki
2011-01-24 23:25 ` [PATCH 0/8] ACPI: Fixes and cleanups related to iomaps management (v2) Rafael J. Wysocki
2011-01-24 23:26   ` [PATCH 1/8] ACPI: Fix acpi_os_read_memory() and acpi_os_write_memory() (v2) Rafael J. Wysocki
2011-01-24 23:27   ` [PATCH 2/8] ACPI: Do not export functions that are only used in osl.c Rafael J. Wysocki
2011-01-24 23:28   ` [PATCH 3/8] ACPI: Change acpi_ioremap_lock into a mutex Rafael J. Wysocki
2011-01-24 23:28   ` [PATCH 4/8] ACPI: Avoid walking the list of memory mappings in osl.c twice in a row Rafael J. Wysocki
2011-01-24 23:29   ` [PATCH 5/8] ACPI: Make acpi_os_map_memory() avoid creating unnecessary mappings Rafael J. Wysocki
2011-01-24 23:30   ` [PATCH 6/8] ACPI: Do not use krefs under a mutex in osl.c Rafael J. Wysocki
2011-01-24 23:30   ` [PATCH 7/8] ACPI: Introduce acpi_os_get_iomem() Rafael J. Wysocki
2011-01-24 23:32   ` [PATCH 8/8] ACPI / PM: Use existing ACPI iomaps for NVS save/restore (v2) Rafael J. Wysocki
2011-02-05 15:31     ` Jeff Chua
2011-02-05 18:20       ` Rafael J. Wysocki
2011-02-05 18:24       ` Rafael J. Wysocki
2011-02-05 18:51       ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2011-01-25  9:43 [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Jeff Chua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101232135.32510.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=jeff.chua.linux@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox