From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: Jeff Chua <jeff.chua.linux@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Linux-pm mailing list" <linux-pm@lists.linux-foundation.org>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: [PATCH 2/8] ACPI: Do not export functions that are only used in osl.c
Date: Tue, 25 Jan 2011 00:27:37 +0100 [thread overview]
Message-ID: <201101250027.37509.rjw@sisk.pl> (raw)
In-Reply-To: <201101250025.10817.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
The functions acpi_os_map_generic_address() and
acpi_os_unmap_generic_address() are only used in drivers/acpi/osl.c,
so make them static and remove the extern definitions of them from
include/linux/acpi_io.h.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/acpi/osl.c | 6 ++----
include/linux/acpi_io.h | 3 ---
2 files changed, 2 insertions(+), 7 deletions(-)
Index: linux-2.6/drivers/acpi/osl.c
===================================================================
--- linux-2.6.orig/drivers/acpi/osl.c
+++ linux-2.6/drivers/acpi/osl.c
@@ -397,7 +397,7 @@ void __init early_acpi_os_unmap_memory(v
__acpi_unmap_table(virt, size);
}
-int acpi_os_map_generic_address(struct acpi_generic_address *addr)
+static int acpi_os_map_generic_address(struct acpi_generic_address *addr)
{
void __iomem *virt;
@@ -413,9 +413,8 @@ int acpi_os_map_generic_address(struct a
return 0;
}
-EXPORT_SYMBOL_GPL(acpi_os_map_generic_address);
-void acpi_os_unmap_generic_address(struct acpi_generic_address *addr)
+static void acpi_os_unmap_generic_address(struct acpi_generic_address *addr)
{
void __iomem *virt;
unsigned long flags;
@@ -433,7 +432,6 @@ void acpi_os_unmap_generic_address(struc
acpi_os_unmap_memory(virt, size);
}
-EXPORT_SYMBOL_GPL(acpi_os_unmap_generic_address);
#ifdef ACPI_FUTURE_USAGE
acpi_status
Index: linux-2.6/include/linux/acpi_io.h
===================================================================
--- linux-2.6.orig/include/linux/acpi_io.h
+++ linux-2.6/include/linux/acpi_io.h
@@ -10,7 +10,4 @@ static inline void __iomem *acpi_os_iore
return ioremap_cache(phys, size);
}
-int acpi_os_map_generic_address(struct acpi_generic_address *addr);
-void acpi_os_unmap_generic_address(struct acpi_generic_address *addr);
-
#endif
next prev parent reply other threads:[~2011-01-24 23:33 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 11:26 [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Rafael J. Wysocki
2011-01-20 11:27 ` [PATCH 1/11] ACPI: Introduce acpi_os_ioremap() Rafael J. Wysocki
2011-01-20 11:28 ` [PATCH 2/11] ACPI / PM: Call suspend_nvs_free() earlier during resume Rafael J. Wysocki
2011-01-20 11:30 ` [PATCH 3/11] ACPI: Fix acpi_os_read_memory() and acpi_os_write_memory() Rafael J. Wysocki
2011-01-20 11:30 ` [PATCH 4/11] ACPI: Do not export functions that are only used in osl.c Rafael J. Wysocki
2011-01-20 11:31 ` [PATCH 5/11] ACPI: Change acpi_ioremap_lock into a mutex Rafael J. Wysocki
2011-01-20 11:32 ` [PATCH 6/11] ACPI: Avoid walking the list of iomaps in osl.c twice in a row Rafael J. Wysocki
2011-01-20 11:33 ` [PATCH 7/11] ACPI: Make acpi_os_map_memory() avoid creating unnecessary mappings Rafael J. Wysocki
2011-01-20 11:34 ` [PATCH 8/11] ACPI: Do not use krefs under a mutex in osl.c Rafael J. Wysocki
2011-01-20 11:35 ` [PATCH 9/11] ACPI: Introduce acpi_os_get_iomem() Rafael J. Wysocki
2011-01-20 11:36 ` [PATCH 10/11] ACPI / PM: Use existing ACPI iomaps for NVS save/restore Rafael J. Wysocki
2011-01-20 11:37 ` [PATCH 11/11] ACPI / PM: Make NVS save/restore code use slightly less memory Rafael J. Wysocki
2011-01-20 16:06 ` [PATCH 0/11] ACPI: Fixes and cleanups related to iomaps management Jeff Chua
2011-01-20 20:57 ` Rafael J. Wysocki
2011-01-20 21:46 ` Jeff Chua
2011-01-21 0:04 ` Rafael J. Wysocki
2011-01-21 2:51 ` Jeff Chua
2011-01-21 12:01 ` Rafael J. Wysocki
2011-01-21 21:06 ` Rafael J. Wysocki
2011-01-22 5:54 ` Jeff Chua
2011-01-22 5:58 ` Jeff Chua
2011-01-22 9:25 ` Rafael J. Wysocki
2011-01-22 17:24 ` Jeff Chua
2011-01-22 19:12 ` Rafael J. Wysocki
2011-01-23 0:14 ` Jeff Chua
2011-01-23 20:28 ` Rafael J. Wysocki
2011-01-24 1:13 ` Jeff Chua
2011-01-24 21:36 ` Rafael J. Wysocki
2011-01-22 9:13 ` Rafael J. Wysocki
2011-01-23 18:20 ` Henrique de Moraes Holschuh
2011-01-23 20:35 ` Rafael J. Wysocki
2011-01-23 23:15 ` Henrique de Moraes Holschuh
2011-01-24 21:37 ` Rafael J. Wysocki
2011-01-24 23:25 ` [PATCH 0/8] ACPI: Fixes and cleanups related to iomaps management (v2) Rafael J. Wysocki
2011-01-24 23:26 ` [PATCH 1/8] ACPI: Fix acpi_os_read_memory() and acpi_os_write_memory() (v2) Rafael J. Wysocki
2011-01-24 23:27 ` Rafael J. Wysocki [this message]
2011-01-24 23:28 ` [PATCH 3/8] ACPI: Change acpi_ioremap_lock into a mutex Rafael J. Wysocki
2011-01-24 23:28 ` [PATCH 4/8] ACPI: Avoid walking the list of memory mappings in osl.c twice in a row Rafael J. Wysocki
2011-01-24 23:29 ` [PATCH 5/8] ACPI: Make acpi_os_map_memory() avoid creating unnecessary mappings Rafael J. Wysocki
2011-01-24 23:30 ` [PATCH 6/8] ACPI: Do not use krefs under a mutex in osl.c Rafael J. Wysocki
2011-01-24 23:30 ` [PATCH 7/8] ACPI: Introduce acpi_os_get_iomem() Rafael J. Wysocki
2011-01-24 23:32 ` [PATCH 8/8] ACPI / PM: Use existing ACPI iomaps for NVS save/restore (v2) Rafael J. Wysocki
2011-02-05 15:31 ` Jeff Chua
2011-02-05 18:20 ` Rafael J. Wysocki
2011-02-05 18:24 ` Rafael J. Wysocki
2011-02-05 18:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101250027.37509.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=jeff.chua.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox