* [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver
@ 2011-01-20 21:47 Mark Brown
2011-01-21 0:16 ` Kyungmin Park
2011-01-31 0:48 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2011-01-20 21:47 UTC (permalink / raw)
To: Kyungmin Park, Samuel Ortiz, MyungJoo Ham; +Cc: linux-kernel, Mark Brown
No need to have them in the global namespace and sparse complains.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/max8998.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
index bbfe867..c002142 100644
--- a/drivers/mfd/max8998.c
+++ b/drivers/mfd/max8998.c
@@ -233,7 +233,7 @@ struct max8998_reg_dump {
u8 val;
};
#define SAVE_ITEM(x) { .addr = (x), .val = 0x0, }
-struct max8998_reg_dump max8998_dump[] = {
+static struct max8998_reg_dump max8998_dump[] = {
SAVE_ITEM(MAX8998_REG_IRQM1),
SAVE_ITEM(MAX8998_REG_IRQM2),
SAVE_ITEM(MAX8998_REG_IRQM3),
@@ -298,7 +298,7 @@ static int max8998_restore(struct device *dev)
return 0;
}
-const struct dev_pm_ops max8998_pm = {
+static const struct dev_pm_ops max8998_pm = {
.suspend = max8998_suspend,
.resume = max8998_resume,
.freeze = max8998_freeze,
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver
2011-01-20 21:47 [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver Mark Brown
@ 2011-01-21 0:16 ` Kyungmin Park
2011-01-31 0:48 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Kyungmin Park @ 2011-01-21 0:16 UTC (permalink / raw)
To: Mark Brown; +Cc: Samuel Ortiz, MyungJoo Ham, linux-kernel
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
On Fri, Jan 21, 2011 at 6:47 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> No need to have them in the global namespace and sparse complains.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/max8998.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index bbfe867..c002142 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -233,7 +233,7 @@ struct max8998_reg_dump {
> u8 val;
> };
> #define SAVE_ITEM(x) { .addr = (x), .val = 0x0, }
> -struct max8998_reg_dump max8998_dump[] = {
> +static struct max8998_reg_dump max8998_dump[] = {
> SAVE_ITEM(MAX8998_REG_IRQM1),
> SAVE_ITEM(MAX8998_REG_IRQM2),
> SAVE_ITEM(MAX8998_REG_IRQM3),
> @@ -298,7 +298,7 @@ static int max8998_restore(struct device *dev)
> return 0;
> }
>
> -const struct dev_pm_ops max8998_pm = {
> +static const struct dev_pm_ops max8998_pm = {
> .suspend = max8998_suspend,
> .resume = max8998_resume,
> .freeze = max8998_freeze,
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver
2011-01-20 21:47 [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver Mark Brown
2011-01-21 0:16 ` Kyungmin Park
@ 2011-01-31 0:48 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2011-01-31 0:48 UTC (permalink / raw)
To: Mark Brown; +Cc: Kyungmin Park, MyungJoo Ham, linux-kernel
Hi Mark,
On Thu, Jan 20, 2011 at 09:47:31PM +0000, Mark Brown wrote:
> No need to have them in the global namespace and sparse complains.
Thanks, patch applied.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-31 0:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-20 21:47 [PATCH] mfd: Staticise non-exported symbols in MAX8998 driver Mark Brown
2011-01-21 0:16 ` Kyungmin Park
2011-01-31 0:48 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox