[Patch] Patch for bug #13853

[Patch] Patch for bug #13853

[jinqiu yang]

Hi everyone,

There is a patch generated by the tool R2Fix for bug #13853.
The problem still exist in latest version.
Could you please take a look at them? Thanks!

--- linux-2.6.30/drivers/net/ariadne.c	2009-06-09 23:05:27.000000000 -0400
+++ /tmp/cocci-output-13571-c63aba-ariadne.c	2011-02-21 17:50:37.625039103 -0500
@@ -421,7 +421,7 @@ static inline void ariadne_reset(struct
 static irqreturn_t ariadne_interrupt(int irq, void *data)
 {
     struct net_device *dev = (struct net_device *)data;
-    volatile struct Am79C960 *lance = (struct Am79C960*)dev->base_addr;
+    volatile struct Am79C960 *lance;
     struct ariadne_private *priv;
     int csr0, boguscnt;
     int handled = 0;
@@ -430,6 +430,7 @@ static irqreturn_t ariadne_interrupt(int
 	printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n");
 	return IRQ_NONE;
     }
+    lance = (struct Am79C960 *)dev->base_addr;

     lance->RAP = CSR0;			/* PCnet-ISA Controller Status */


Best,
Jinqiu

Re: [Patch] Patch for bug #13853

[David Miller]

From: jinqiu yang <crindy646@gmail.com>
Date: Wed, 2 Mar 2011 16:10:25 -0500

> Hi everyone,
> 
> There is a patch generated by the tool R2Fix for bug #13853.
> The problem still exist in latest version.
> Could you please take a look at them? Thanks!
> 
> --- linux-2.6.30/drivers/net/ariadne.c	2009-06-09 23:05:27.000000000 -0400
> +++ /tmp/cocci-output-13571-c63aba-ariadne.c	2011-02-21 17:50:37.625039103 -0500
> @@ -421,7 +421,7 @@ static inline void ariadne_reset(struct

These paths in your patch are incorrect and your email client
has corrupted the patch, turning tab characters into spaces etc.

You are also missing a proper "Signed-off-by: " line in your
commit message, and your Subject needs to be more properly formed
to describe what this patch is for.

Please invest some time reading Documentation/SubmittingPatches
and Documentation/email-clients.txt before trying to send this
patch again.

Thanks.