From: Stephen Hemminger <shemminger@vyatta.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] drivers: make device_type const
Date: Mon, 28 Mar 2011 09:12:52 -0700 [thread overview]
Message-ID: <20110328091252.75a22583@nehalam> (raw)
The device_type structure does not contain data that changes
during usage and should be const. This allows devices to declare
the struct const.
I have patches to change all the subsystems, but need the infra
structure change first.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
drivers/base/core.c | 4 ++--
include/linux/device.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/base/core.c 2011-03-28 08:48:43.380836767 -0700
+++ b/drivers/base/core.c 2011-03-28 08:48:46.228868558 -0700
@@ -400,7 +400,7 @@ static void device_remove_groups(struct
static int device_add_attrs(struct device *dev)
{
struct class *class = dev->class;
- struct device_type *type = dev->type;
+ const struct device_type *type = dev->type;
int error;
if (class) {
@@ -440,7 +440,7 @@ static int device_add_attrs(struct devic
static void device_remove_attrs(struct device *dev)
{
struct class *class = dev->class;
- struct device_type *type = dev->type;
+ const struct device_type *type = dev->type;
device_remove_groups(dev, dev->groups);
--- a/include/linux/device.h 2011-03-28 08:48:43.392836902 -0700
+++ b/include/linux/device.h 2011-03-28 08:48:46.228868558 -0700
@@ -408,7 +408,7 @@ struct device {
struct kobject kobj;
const char *init_name; /* initial name of the device */
- struct device_type *type;
+ const struct device_type *type;
struct mutex mutex; /* mutex to synchronize calls to
* its driver.
reply other threads:[~2011-03-28 16:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328091252.75a22583@nehalam \
--to=shemminger@vyatta.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox