public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: make device_type const
@ 2011-03-28 16:12 Stephen Hemminger
  0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2011-03-28 16:12 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel

The device_type structure does not contain data that changes
during usage and should be const. This allows devices to declare
the struct const.

I have patches to change all the subsystems, but need the infra
structure change first.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
 drivers/base/core.c    |    4 ++--
 include/linux/device.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/base/core.c	2011-03-28 08:48:43.380836767 -0700
+++ b/drivers/base/core.c	2011-03-28 08:48:46.228868558 -0700
@@ -400,7 +400,7 @@ static void device_remove_groups(struct
 static int device_add_attrs(struct device *dev)
 {
 	struct class *class = dev->class;
-	struct device_type *type = dev->type;
+	const struct device_type *type = dev->type;
 	int error;
 
 	if (class) {
@@ -440,7 +440,7 @@ static int device_add_attrs(struct devic
 static void device_remove_attrs(struct device *dev)
 {
 	struct class *class = dev->class;
-	struct device_type *type = dev->type;
+	const struct device_type *type = dev->type;
 
 	device_remove_groups(dev, dev->groups);
 
--- a/include/linux/device.h	2011-03-28 08:48:43.392836902 -0700
+++ b/include/linux/device.h	2011-03-28 08:48:46.228868558 -0700
@@ -408,7 +408,7 @@ struct device {
 
 	struct kobject kobj;
 	const char		*init_name; /* initial name of the device */
-	struct device_type	*type;
+	const struct device_type *type;
 
 	struct mutex		mutex;	/* mutex to synchronize calls to
 					 * its driver.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-03-28 16:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 16:12 [PATCH] drivers: make device_type const Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox