* Compile errors for SynthHid @ 2011-04-11 20:01 Andrei Warkentin 2011-04-11 20:01 ` [PATCH] HV SynthHID: Fix compile error Andrei Warkentin 0 siblings, 1 reply; 4+ messages in thread From: Andrei Warkentin @ 2011-04-11 20:01 UTC (permalink / raw) To: linux-kernel; +Cc: gregkh, hjanssen, haiyangz I just tried building linux-next tree and hit a simple compile error. ToC: [PATCH] HV SynthHID: Fix compile error. Thanks, A ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] HV SynthHID: Fix compile error. 2011-04-11 20:01 Compile errors for SynthHid Andrei Warkentin @ 2011-04-11 20:01 ` Andrei Warkentin 2011-04-11 19:27 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Andrei Warkentin @ 2011-04-11 20:01 UTC (permalink / raw) To: linux-kernel; +Cc: gregkh, hjanssen, haiyangz, Andrei Warkentin Missing include for <asm/delay.h> Signed-off-by: Andrei Warkentin <andreiw@motorola.com> --- drivers/staging/hv/hv_mouse.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c index 50147f8..c5020c0 100644 --- a/drivers/staging/hv/hv_mouse.c +++ b/drivers/staging/hv/hv_mouse.c @@ -23,6 +23,7 @@ #include <linux/hiddev.h> #include <linux/pci.h> #include <linux/dmi.h> +#include <asm/delay.h> #include "hv_api.h" #include "logging.h" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HV SynthHID: Fix compile error. 2011-04-11 20:01 ` [PATCH] HV SynthHID: Fix compile error Andrei Warkentin @ 2011-04-11 19:27 ` Greg KH 2011-04-11 20:14 ` Andrei Warkentin 0 siblings, 1 reply; 4+ messages in thread From: Greg KH @ 2011-04-11 19:27 UTC (permalink / raw) To: Andrei Warkentin; +Cc: linux-kernel, hjanssen, haiyangz On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote: > Missing include for <asm/delay.h> > > Signed-off-by: Andrei Warkentin <andreiw@motorola.com> > --- > drivers/staging/hv/hv_mouse.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c > index 50147f8..c5020c0 100644 > --- a/drivers/staging/hv/hv_mouse.c > +++ b/drivers/staging/hv/hv_mouse.c > @@ -23,6 +23,7 @@ > #include <linux/hiddev.h> > #include <linux/pci.h> > #include <linux/dmi.h> > +#include <asm/delay.h> Never include "<asm/" include files if at all possible. Anyway, this should already be fixed in Linus's tree, right? thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HV SynthHID: Fix compile error. 2011-04-11 19:27 ` Greg KH @ 2011-04-11 20:14 ` Andrei Warkentin 0 siblings, 0 replies; 4+ messages in thread From: Andrei Warkentin @ 2011-04-11 20:14 UTC (permalink / raw) To: Greg KH; +Cc: linux-kernel, hjanssen, haiyangz On Mon, Apr 11, 2011 at 2:27 PM, Greg KH <gregkh@suse.de> wrote: > On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote: >> Missing include for <asm/delay.h> >> >> Signed-off-by: Andrei Warkentin <andreiw@motorola.com> >> --- >> drivers/staging/hv/hv_mouse.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c >> index 50147f8..c5020c0 100644 >> --- a/drivers/staging/hv/hv_mouse.c >> +++ b/drivers/staging/hv/hv_mouse.c >> @@ -23,6 +23,7 @@ >> #include <linux/hiddev.h> >> #include <linux/pci.h> >> #include <linux/dmi.h> >> +#include <asm/delay.h> > > Never include "<asm/" include files if at all possible. > Oops, alright, will do. > Anyway, this should already be fixed in Linus's tree, right? > Sorry no clue, if so, thanks ahead. I was testing something else in SD/MMC-land and wanted to make sure it compiled cleanly on x86/x64. A ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-04-11 20:14 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-04-11 20:01 Compile errors for SynthHid Andrei Warkentin 2011-04-11 20:01 ` [PATCH] HV SynthHID: Fix compile error Andrei Warkentin 2011-04-11 19:27 ` Greg KH 2011-04-11 20:14 ` Andrei Warkentin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox