* [PATCH] sched: remove hrtick_enabled()
@ 2011-04-18 12:27 Hillf Danton
2011-04-18 13:04 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Hillf Danton @ 2011-04-18 12:27 UTC (permalink / raw)
To: LKML; +Cc: Ingo Molnar, Peter Zijlstra
The function, hrtick_enabled(), could be removed, since it is not used
anywhere, though defined.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/kernel/sched.c 2011-03-30 03:09:48.000000000 +0800
+++ b/kernel/sched.c 2011-04-18 20:28:22.000000000 +0800
@@ -994,20 +994,6 @@ static struct rq *this_rq_lock(void)
* rq->lock.
*/
-/*
- * Use hrtick when:
- * - enabled by features
- * - hrtimer is actually high res
- */
-static inline int hrtick_enabled(struct rq *rq)
-{
- if (!sched_feat(HRTICK))
- return 0;
- if (!cpu_active(cpu_of(rq)))
- return 0;
- return hrtimer_is_hres_active(&rq->hrtick_timer);
-}
-
static void hrtick_clear(struct rq *rq)
{
if (hrtimer_active(&rq->hrtick_timer))
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched: remove hrtick_enabled()
2011-04-18 12:27 [PATCH] sched: remove hrtick_enabled() Hillf Danton
@ 2011-04-18 13:04 ` Ingo Molnar
2011-04-18 13:25 ` Hillf Danton
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2011-04-18 13:04 UTC (permalink / raw)
To: Hillf Danton; +Cc: LKML, Peter Zijlstra
* Hillf Danton <dhillf@gmail.com> wrote:
> The function, hrtick_enabled(), could be removed, since it is not used
> anywhere, though defined.
Well, what about kernel/sched_fair.c?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: remove hrtick_enabled()
2011-04-18 13:04 ` Ingo Molnar
@ 2011-04-18 13:25 ` Hillf Danton
0 siblings, 0 replies; 3+ messages in thread
From: Hillf Danton @ 2011-04-18 13:25 UTC (permalink / raw)
To: Ingo Molnar; +Cc: LKML, Peter Zijlstra
On Mon, Apr 18, 2011 at 9:04 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Hillf Danton <dhillf@gmail.com> wrote:
>
>> The function, hrtick_enabled(), could be removed, since it is not used
>> anywhere, though defined.
>
> Well, what about kernel/sched_fair.c?
>
Yeah, the tricky is #include "sched-fair.c", though the removed is static.
Thanks,
Hillf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-18 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-18 12:27 [PATCH] sched: remove hrtick_enabled() Hillf Danton
2011-04-18 13:04 ` Ingo Molnar
2011-04-18 13:25 ` Hillf Danton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox