From: Andi Kleen <ak@linux.intel.com>
To: Eric Paris <eparis@parisplace.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
npiggin@kernel.dk, shaohua.li@intel.com, sds@tycho.nsa.gov,
jmorris@namei.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/3] SELINUX: Make selinux cache VFS RCU walks safe
Date: Fri, 22 Apr 2011 08:16:19 -0700 [thread overview]
Message-ID: <20110422151619.GA10755@tassilo.jf.intel.com> (raw)
In-Reply-To: <BANLkTik2Pc=A1b41oNanZ--bsX0OHhbA+w@mail.gmail.com>
On Thu, Apr 21, 2011 at 08:45:17PM -0400, Eric Paris wrote:
> I'll take a close look over the weekend, but I'm pretty sure this is
> even more strict than it needs to be. I looked at this a while ago
> and the only RCU unsafe location I could find was in the generic LSM
> 'audit' code (nothing to do with the audit subsystem). That code can
> do a d = d_find_alias(); dput(d). I don't think I realized the dput()
> was not RCU safe at the time. We use it to come up with a name of a
> dentry that might have caused the denial (although obviously not
> necessarily the right name)
>
> I could just drop that piece of functionality (and rely on the audit
> subsystem for the info), but I think I'd rather do it your way. I
> think I can push your flags a lot deeper than you have pushed them
> (and remove them in some places you have included them). Let me look
> over the next day or two....
Sounds good. I would prefer to do that as a follow on patch to make
this patch not even more complicated. Is that ok for you?
Also the same approach could be applied to SMACK then I guess.
-Andi
next prev parent reply other threads:[~2011-04-22 15:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 0:23 Make RCU dcache work with CONFIG_SECURITY=y Andi Kleen
2011-04-22 0:23 ` [PATCH 1/3] SECURITY: Move exec_permission RCU checks into security modules Andi Kleen
2011-04-22 0:46 ` Eric Paris
2011-04-22 4:34 ` Christoph Hellwig
2011-04-22 15:25 ` Andi Kleen
2011-04-22 15:27 ` Christoph Hellwig
2011-04-22 0:23 ` [PATCH 2/3] SELINUX: Make selinux cache VFS RCU walks safe Andi Kleen
2011-04-22 0:45 ` Eric Paris
2011-04-22 15:16 ` Andi Kleen [this message]
2011-04-22 0:23 ` [PATCH 3/3] SMACK: Make smack directory access check RCU safe Andi Kleen
2011-04-22 1:40 ` Make RCU dcache work with CONFIG_SECURITY=y Shaohua Li
2011-04-22 18:26 ` Linus Torvalds
2011-04-22 21:16 ` Andi Kleen
2011-04-22 21:32 ` Casey Schaufler
2011-04-22 21:17 ` Eric Paris
2011-04-22 23:29 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422151619.GA10755@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=sds@tycho.nsa.gov \
--cc=shaohua.li@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox