Re: [PATCH 2/2] Staging: comedi: fix tabulation and over 80 chars issues in amplc_pci224.c This is a patch to the amplc_pci224.c file that fixes up tabulation style errors and over 80 chars warning found by the checkpatch.pl tool Signed-off-by: Steph

Re: [PATCH 2/2] Staging: comedi: fix tabulation and over 80 chars issues in amplc_pci224.c This is a patch to the amplc_pci224.c file that fixes up tabulation style errors and over 80 chars warning found by the checkpatch.pl tool Signed-off-by: Steph

[Greg KH]

On Thu, May 12, 2011 at 06:47:32PM +0200, Stéphane Pajot wrote:
> Hi Everybody,
> 
> Really sorry for the bug title with git send-email ... is there a way to avoid
> it ?

Yes, put a blank line in your changelog commit after the first line, and
git format-patch will do it correctly.

thanks,

greg k-h

Re: [PATCH 2/2] Staging: comedi: fix tabulation and over 80 chars issues in amplc_pci224.c This is a patch to the amplc_pci224.c file that fixes up tabulation style errors and over 80 chars warning found by the checkpatch.pl tool Signed-off-by: Steph

[Greg KH]

On Thu, May 12, 2011 at 10:03:35PM +0200, Stéphane Pajot wrote:
> My answer in purple :

Purple doesn't show up in plain text email clients :(

> 2011/5/12 Greg KH <gregkh@suse.de>
> 
>     On Thu, May 12, 2011 at 06:44:58PM +0200, Stephane Pajot wrote:
>     > ---
>     >  drivers/staging/comedi/drivers/amplc_pci224.c |   63
>     +++++++++++++------------
>     >  1 files changed, 33 insertions(+), 30 deletions(-)
>     >
>     > diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/
>     staging/comedi/drivers/amplc_pci224.c
>     > index 1b5ba1c..2f61358 100644
>     > --- a/drivers/staging/comedi/drivers/amplc_pci224.c
>     > +++ b/drivers/staging/comedi/drivers/amplc_pci224.c
>     > @@ -52,33 +52,33 @@ Supports:
>     >  Configuration options - PCI224:
>     >    [0] - PCI bus of device (optional).
>     >    [1] - PCI slot of device (optional).
>     > -          If bus/slot is not specified, the first available PCI device
>     > -          will be used.
>     > +     If bus/slot is not specified, the first available PCI device
>     > +     will be used.
> 
>     Why did you change these comment lines ? 
> 
> 
> I change the space by a tabulation. Checkpatch.pl return errors about that
> (maybe it's a mistake...). Question : when checkpatch.pl return this kind of
> error (tabulation, or style in general) do we have to correct it too ?    

Just leave it alone, checkpatch isn't always correct, it's a guideline.

thanks,

greg k-h