[PATCH] gpiolib: export gpiochip_find

[PATCH] gpiolib: export gpiochip_find

[Jean Delvare]

Export function gpiochip_find so that modules can use it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
---
I need this to add support for SMBus multiplexing on my Asus Z8NA-D6
board.

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.39-rc3.orig/drivers/gpio/gpiolib.c	2011-03-30 10:57:19.000000000 +0200
+++ linux-2.6.39-rc3/drivers/gpio/gpiolib.c	2011-04-16 09:00:25.000000000 +0200
@@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
 
 	return chip;
 }
+EXPORT_SYMBOL_GPL(gpiochip_find);
 
 /* These "optional" allocation calls help prevent drivers from stomping
  * on each other, and help provide better diagnostics in debugfs.


-- 
Jean Delvare

Re: [PATCH] gpiolib: export gpiochip_find

[Jean Delvare]

Hi Grant,

On Sat, 16 Apr 2011 09:30:15 +0200, Jean Delvare wrote:
> Export function gpiochip_find so that modules can use it.

Any problem with this patch? If not, the earlier it gets upstream, the
happier I'll be. I think it should even be considered for stable kernel
series.

Thanks.

> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> ---
> I need this to add support for SMBus multiplexing on my Asus Z8NA-D6
> board.
> 
>  drivers/gpio/gpiolib.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-2.6.39-rc3.orig/drivers/gpio/gpiolib.c	2011-03-30 10:57:19.000000000 +0200
> +++ linux-2.6.39-rc3/drivers/gpio/gpiolib.c	2011-04-16 09:00:25.000000000 +0200
> @@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
>  
>  	return chip;
>  }
> +EXPORT_SYMBOL_GPL(gpiochip_find);
>  
>  /* These "optional" allocation calls help prevent drivers from stomping
>   * on each other, and help provide better diagnostics in debugfs.
> 

-- 
Jean Delvare

Re: [PATCH] gpiolib: export gpiochip_find

[Jean Delvare]

Hi Grant,

On Sat, 16 Apr 2011 09:30:15 +0200, Jean Delvare wrote:
> Export function gpiochip_find so that modules can use it.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> ---
> I need this to add support for SMBus multiplexing on my Asus Z8NA-D6
> board.
> 
>  drivers/gpio/gpiolib.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-2.6.39-rc3.orig/drivers/gpio/gpiolib.c	2011-03-30 10:57:19.000000000 +0200
> +++ linux-2.6.39-rc3/drivers/gpio/gpiolib.c	2011-04-16 09:00:25.000000000 +0200
> @@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
>  
>  	return chip;
>  }
> +EXPORT_SYMBOL_GPL(gpiochip_find);
>  
>  /* These "optional" allocation calls help prevent drivers from stomping
>   * on each other, and help provide better diagnostics in debugfs.

I am sorry to insist, but this patch seems quite straightforward, it
shouldn't take long to review. Do you have any problem with it? If not,
please apply it. I really would like to have it in kernel 2.6.40, as
the rest of my SMBus multiplexing support effort depends on it.

Thanks,
-- 
Jean Delvare

Re: [PATCH] gpiolib: export gpiochip_find

[Grant Likely]

On Fri, May 13, 2011 at 10:52:20AM +0200, Jean Delvare wrote:
> Hi Grant,
> 
> On Sat, 16 Apr 2011 09:30:15 +0200, Jean Delvare wrote:
> > Export function gpiochip_find so that modules can use it.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > ---
> > I need this to add support for SMBus multiplexing on my Asus Z8NA-D6
> > board.
> > 
> >  drivers/gpio/gpiolib.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- linux-2.6.39-rc3.orig/drivers/gpio/gpiolib.c	2011-03-30 10:57:19.000000000 +0200
> > +++ linux-2.6.39-rc3/drivers/gpio/gpiolib.c	2011-04-16 09:00:25.000000000 +0200
> > @@ -1165,6 +1165,7 @@ struct gpio_chip *gpiochip_find(void *da
> >  
> >  	return chip;
> >  }
> > +EXPORT_SYMBOL_GPL(gpiochip_find);
> >  
> >  /* These "optional" allocation calls help prevent drivers from stomping
> >   * on each other, and help provide better diagnostics in debugfs.
> 
> I am sorry to insist, but this patch seems quite straightforward, it
> shouldn't take long to review. Do you have any problem with it? If not,
> please apply it. I really would like to have it in kernel 2.6.40, as
> the rest of my SMBus multiplexing support effort depends on it.

Merged, thanks.

Sorry for the delay.  All the activity around UDS and getting the
ARM device tree patches into a state ready for merging pretty much
eliminated any chance I've had to look at gpio stuff over the last
month.  :-(  I'm trying to get through the backlog now.

g.

Re: [PATCH] gpiolib: export gpiochip_find

[Jean Delvare]

On Sun, 15 May 2011 15:35:50 -0600, Grant Likely wrote:
> Sorry for the delay.  All the activity around UDS and getting the
> ARM device tree patches into a state ready for merging pretty much
> eliminated any chance I've had to look at gpio stuff over the last
> month.  :-(  I'm trying to get through the backlog now.

I understand, no problem. It's just in time for 2.6.40, as I needed, so
it's OK. Thanks!

-- 
Jean Delvare