From: Jean Delvare <khali@linux-fr.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Grant Likely <grant.likely@secretlab.ca>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins
Date: Thu, 19 May 2011 13:33:44 +0200 [thread overview]
Message-ID: <20110519133344.285a6a14@endymion.delvare> (raw)
In-Reply-To: <20110423154707.454e1010@lxorguk.ukuu.org.uk>
Hi Alan, Grant,
On Sat, 23 Apr 2011 15:47:07 +0100, Alan Cox wrote:
> > And a technical question (which makes me feel somewhat ashamed as I
> > guess I really should know the answer): the ICH is using I/O ports for
> > GPIO control, not a memory mapping. Would basic_mmio_gpio work for it
> > still?
>
> basic_mmio_gpio would need to use iomap for this and a lot of platforms
> don't support generic iomap - so no it won't.
>
> You don't generally want want to create sub platform devices anyway
> without care as it makes sysfs, pci removal and power management ugly and
> takes up *more* memory than repeating the code in the first places.
OK, so given that I can't use basic_mmio_gpio and Alan thinks that
having an independent driver is the way to go anyway, is there any
chance to get my code reviewed and merged? I am using it since the day
I submitted it (one month ago), it appears to work fine for me, and
it is a mandatory piece to support SMBus multiplexing on many x86 server
boards. I'd like to see it happen in kernel 2.6.40.
I can resend the patch if it helps, but I did not make any change to
the code since the first submission.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2011-05-19 11:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 12:53 [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins Jean Delvare
2011-04-19 14:44 ` Grant Likely
2011-04-19 14:54 ` Alan Cox
2011-04-19 15:05 ` Grant Likely
2011-04-19 15:57 ` Alan Cox
2011-04-19 16:40 ` Anton Vorontsov
2011-04-19 17:08 ` Alan Cox
2011-04-19 20:30 ` Anton Vorontsov
2011-04-19 21:16 ` Alan Cox
2011-04-19 21:20 ` Alan Cox
2011-04-23 13:45 ` Jean Delvare
2011-04-23 14:47 ` Alan Cox
2011-05-19 11:33 ` Jean Delvare [this message]
2011-05-27 3:09 ` Grant Likely
2012-02-02 2:31 ` Guenter Roeck
2012-02-02 7:49 ` Jean Delvare
2012-02-02 17:35 ` Guenter Roeck
2012-02-02 19:56 ` Peter Tyser
2012-02-02 22:02 ` Guenter Roeck
2012-02-02 23:25 ` [PATCH 1/3] mfd: Add LPC driver for Intel ICH chipsets Aaron Sierra
2012-02-03 6:43 ` Guenter Roeck
2012-02-03 15:34 ` Aaron Sierra
2012-02-03 19:14 ` Guenter Roeck
2012-02-03 19:35 ` Aaron Sierra
2012-02-03 19:45 ` Guenter Roeck
2012-02-03 22:50 ` Aaron Sierra
2012-02-04 8:45 ` Jean Delvare
2012-02-04 16:45 ` Guenter Roeck
2012-02-07 19:56 ` [PATCH 1/3 v2] " Aaron Sierra
2012-02-07 20:15 ` Guenter Roeck
2012-02-07 20:31 ` Jean Delvare
2012-02-07 20:43 ` Guenter Roeck
2012-02-07 21:00 ` Aaron Sierra
2012-02-07 21:09 ` Guenter Roeck
2012-02-02 23:27 ` [PATCH 2/3] gpio: Add support for Intel ICHx/3100/Series[56] GPIO Aaron Sierra
2012-02-03 20:19 ` Guenter Roeck
2012-02-07 19:58 ` [PATCH 2/3 v2] " Aaron Sierra
2012-02-07 20:42 ` Guenter Roeck
2012-02-07 22:07 ` Jean Delvare
2012-02-07 23:25 ` Aaron Sierra
2012-02-02 23:29 ` [PATCH 3/3] watchdog: Convert iTCO_wdt driver to mfd model Aaron Sierra
2012-02-07 19:59 ` [PATCH 3/3 v2] " Aaron Sierra
2012-02-07 21:07 ` Guenter Roeck
2012-02-08 17:48 ` Aaron Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519133344.285a6a14@endymion.delvare \
--to=khali@linux-fr.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox