From: Matthew Garrett <mjg@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, pjones@redhat.com
Subject: Re: [PATCH] x86: CONFIG_EFI should select CONFIG_RELOCATABLE
Date: Thu, 9 Jun 2011 15:47:36 +0100 [thread overview]
Message-ID: <20110609144736.GA27953@srcf.ucam.org> (raw)
In-Reply-To: <4DF0DAAB.7010005@zytor.com>
On Thu, Jun 09, 2011 at 07:37:31AM -0700, H. Peter Anvin wrote:
> On 06/09/2011 07:32 AM, Matthew Garrett wrote:
> > config EFI
> > bool "EFI runtime service support"
> > depends on ACPI
> > + select RELOCATABLE
> > ---help---
> > This enables the kernel to use EFI runtime services that are
> > available (such as the EFI variable services).
>
> Can we make this a depends on instead of select?
CONFIG_RELOCATABLE has no dependencies so select should be safe, and
depends means CONFIG_EFI vanishes until you turn on something that seems
entirely unrelated. I've no problem with it being depends, but this
seems friendlier.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-06-09 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 14:32 [PATCH] x86: CONFIG_EFI should select CONFIG_RELOCATABLE Matthew Garrett
2011-06-09 14:34 ` Peter Jones
2011-06-09 14:37 ` H. Peter Anvin
2011-06-09 14:41 ` Peter Jones
2011-06-09 15:23 ` H. Peter Anvin
2011-06-09 15:35 ` Matthew Garrett
2011-06-09 14:47 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609144736.GA27953@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox