From: Vivek Goyal <vgoyal@redhat.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfq-iosched: allow groups preemption for sync-noidle workloads
Date: Thu, 23 Jun 2011 14:08:54 -0400 [thread overview]
Message-ID: <20110623180854.GE20763@redhat.com> (raw)
In-Reply-To: <20110623162159.3192.87699.stgit@localhost6>
On Thu, Jun 23, 2011 at 08:21:59PM +0400, Konstantin Khlebnikov wrote:
> commit v2.6.32-102-g8682e1f "blkio: Provide some isolation between groups" break
> fast switching between task and journal-thread for very common write-fsync workload.
> cfq wait idle slice at each cfqq switch, if this task is from non-root blkio cgroup.
>
> This patch move idling sync-noidle preempting check little bit upwards and update
> new service_tree->count check for case with two different groups.
> I do not quite understand what means these check for new_cfqq, but now it even works.
>
> Without patch I got 49 iops and with this patch 798, for this trivial fio script:
Which filesystem you are using for these tests?
Vivek
next prev parent reply other threads:[~2011-06-23 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 16:21 [PATCH] cfq-iosched: allow groups preemption for sync-noidle workloads Konstantin Khlebnikov
2011-06-23 17:26 ` Vivek Goyal
2011-06-23 18:38 ` Jeff Moyer
2011-06-23 18:08 ` Vivek Goyal [this message]
2011-06-23 20:34 ` Vivek Goyal
2011-06-24 10:29 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623180854.GE20763@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox