Re: + memcg-fix-reclaimable-lru-check-in-memcg-fix-2.patch added to -mm tree

Re: + memcg-fix-reclaimable-lru-check-in-memcg-fix-2.patch added to -mm tree

[Randy Dunlap]

On Fri, 01 Jul 2011 12:36:20 -0700 akpm@linux-foundation.org wrote:

> 
> The patch titled
>      memcg-fix-reclaimable-lru-check-in-memcg-fix-2
> has been added to the -mm tree.  Its filename is
>      memcg-fix-reclaimable-lru-check-in-memcg-fix-2.patch
> 

Is there some way to get this patch added to linux-next?

thanks.

> ------------------------------------------------------
> Subject: memcg-fix-reclaimable-lru-check-in-memcg-fix-2
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
>  memcg-fix-reclaimable-lru-check-in-memcg.patch
>  causes following error with !CONFIG_NUMA.
> 
> > mmotm-2011-0630-1559/mm/memcontrol.c:1579: error: implicit declaration of function 'mem_cgroup_node_nr_file_lru_pages'
> > mmotm-2011-0630-1559/mm/memcontrol.c:1583: error: implicit declaration of function 'mem_cgroup_node_nr_anon_lru_pages'
> >
> 
> This patch fixes it by moving functions out of #ifdef.
> 
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> cked-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  mm/memcontrol.c |   23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff -puN mm/memcontrol.c~memcg-fix-reclaimable-lru-check-in-memcg-fix-2 mm/memcontrol.c
> --- a/mm/memcontrol.c~memcg-fix-reclaimable-lru-check-in-memcg-fix-2
> +++ a/mm/memcontrol.c
> @@ -1120,7 +1120,6 @@ unsigned long mem_cgroup_zone_nr_lru_pag
>  	return MEM_CGROUP_ZSTAT(mz, lru);
>  }
>  
> -#ifdef CONFIG_NUMA
>  static unsigned long mem_cgroup_node_nr_file_lru_pages(struct mem_cgroup *memcg,
>  							int nid)
>  {
> @@ -1132,6 +1131,17 @@ static unsigned long mem_cgroup_node_nr_
>  	return ret;
>  }
>  
> +static unsigned long mem_cgroup_node_nr_anon_lru_pages(struct mem_cgroup *memcg,
> +							int nid)
> +{
> +	unsigned long ret;
> +
> +	ret = mem_cgroup_get_zonestat_node(memcg, nid, LRU_INACTIVE_ANON) +
> +		mem_cgroup_get_zonestat_node(memcg, nid, LRU_ACTIVE_ANON);
> +	return ret;
> +}
> +
> +#if MAX_NUMNODES > 1
>  static unsigned long mem_cgroup_nr_file_lru_pages(struct mem_cgroup *memcg)
>  {
>  	u64 total = 0;
> @@ -1143,17 +1153,6 @@ static unsigned long mem_cgroup_nr_file_
>  	return total;
>  }
>  
> -static unsigned long mem_cgroup_node_nr_anon_lru_pages(struct mem_cgroup *memcg,
> -							int nid)
> -{
> -	unsigned long ret;
> -
> -	ret = mem_cgroup_get_zonestat_node(memcg, nid, LRU_INACTIVE_ANON) +
> -		mem_cgroup_get_zonestat_node(memcg, nid, LRU_ACTIVE_ANON);
> -
> -	return ret;
> -}
> -
>  static unsigned long mem_cgroup_nr_anon_lru_pages(struct mem_cgroup *memcg)
>  {
>  	u64 total = 0;
> _


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: + memcg-fix-reclaimable-lru-check-in-memcg-fix-2.patch added to -mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi Randy,

On Mon, 4 Jul 2011 13:26:50 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> On Fri, 01 Jul 2011 12:36:20 -0700 akpm@linux-foundation.org wrote:
> 
> > 
> > The patch titled
> >      memcg-fix-reclaimable-lru-check-in-memcg-fix-2
> > has been added to the -mm tree.  Its filename is
> >      memcg-fix-reclaimable-lru-check-in-memcg-fix-2.patch
> > 
> 
> Is there some way to get this patch added to linux-next?

I have added it to my copy of the akpm tree for tody.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]