* [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()
@ 2011-07-22 13:09 Keshava Munegowda
2011-07-26 14:34 ` Felipe Balbi
2011-07-27 9:53 ` Samuel Ortiz
0 siblings, 2 replies; 4+ messages in thread
From: Keshava Munegowda @ 2011-07-22 13:09 UTC (permalink / raw)
To: linux-usb, linux-omap, linux-kernel
Cc: Keshava Munegowda, balbi, gadiyar, sameo, parthab, kishon,
Keshava Munegowda
From: Keshava Munegowda <Keshava_mgowda@ti.com>
usbhs_disable function was invoking clk_enable() instead of
clk_disable(), thus only increasing the clock usage counter and
preventing this particular clock from being ever turned off.
Because of this, the power domain of omap4 the USB Host subsystem
would never reach lower power states.This patch calls clk_disable()
in usbhs_disable function
Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
---
drivers/mfd/omap-usb-host.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 1717144..29601e7 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -998,9 +998,9 @@ static void usbhs_disable(struct device *dev)
if (is_omap_usbhs_rev2(omap)) {
if (is_ehci_tll_mode(pdata->port_mode[0]))
- clk_enable(omap->usbtll_p1_fck);
+ clk_disable(omap->usbtll_p1_fck);
if (is_ehci_tll_mode(pdata->port_mode[1]))
- clk_enable(omap->usbtll_p2_fck);
+ clk_disable(omap->usbtll_p2_fck);
clk_disable(omap->utmi_p2_fck);
clk_disable(omap->utmi_p1_fck);
}
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()
2011-07-22 13:09 [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable() Keshava Munegowda
@ 2011-07-26 14:34 ` Felipe Balbi
2011-07-27 9:53 ` Samuel Ortiz
1 sibling, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2011-07-26 14:34 UTC (permalink / raw)
To: Keshava Munegowda
Cc: linux-usb, linux-omap, linux-kernel, balbi, gadiyar, sameo,
parthab, kishon
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
>
> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Samuel, I guess you can take this via MFD ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()
2011-07-22 13:09 [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable() Keshava Munegowda
2011-07-26 14:34 ` Felipe Balbi
@ 2011-07-27 9:53 ` Samuel Ortiz
2011-07-27 11:15 ` Munegowda, Keshava
1 sibling, 1 reply; 4+ messages in thread
From: Samuel Ortiz @ 2011-07-27 9:53 UTC (permalink / raw)
To: Keshava Munegowda
Cc: linux-usb, linux-omap, linux-kernel, balbi, gadiyar, parthab,
kishon
Hi Keshava,
On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
> Because of this, the power domain of omap4 the USB Host subsystem
> would never reach lower power states.This patch calls clk_disable()
> in usbhs_disable function
I applied this patch now, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable()
2011-07-27 9:53 ` Samuel Ortiz
@ 2011-07-27 11:15 ` Munegowda, Keshava
0 siblings, 0 replies; 4+ messages in thread
From: Munegowda, Keshava @ 2011-07-27 11:15 UTC (permalink / raw)
To: Samuel Ortiz
Cc: linux-usb, linux-omap, linux-kernel, balbi, gadiyar, parthab,
kishon
Thanks samuel
regards
keshava
On Wed, Jul 27, 2011 at 3:23 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Hi Keshava,
>
> On Fri, Jul 22, 2011 at 06:39:30PM +0530, Keshava Munegowda wrote:
>> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>>
>> usbhs_disable function was invoking clk_enable() instead of
>> clk_disable(), thus only increasing the clock usage counter and
>> preventing this particular clock from being ever turned off.
>> Because of this, the power domain of omap4 the USB Host subsystem
>> would never reach lower power states.This patch calls clk_disable()
>> in usbhs_disable function
> I applied this patch now, thanks.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-27 11:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-22 13:09 [PATCH] mfd: omap-usb-host: fix clock API usage on usbhs_disable() Keshava Munegowda
2011-07-26 14:34 ` Felipe Balbi
2011-07-27 9:53 ` Samuel Ortiz
2011-07-27 11:15 ` Munegowda, Keshava
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox