From: Don Zickus <dzickus@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] watchdog: NUMA affine kthreads
Date: Thu, 28 Jul 2011 16:05:32 -0400 [thread overview]
Message-ID: <20110728200532.GP2581@redhat.com> (raw)
In-Reply-To: <1311871468.2346.28.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Thu, Jul 28, 2011 at 06:44:28PM +0200, Eric Dumazet wrote:
> watchdog kthreads can use kthread_create_on_node() to NUMA affine their
> stack and task_struct.
Looks good, I'll apply and test it.
Thanks.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Don Zickus <dzickus@redhat.com>
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/watchdog.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 36491cd..14cabcd 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
>
> /* create the watchdog thread */
> if (!p) {
> - p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
> + p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
> + "watchdog/%d", cpu);
> if (IS_ERR(p)) {
> printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
> if (!err) {
>
>
next prev parent reply other threads:[~2011-07-28 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 16:44 [PATCH] watchdog: NUMA affine kthreads Eric Dumazet
2011-07-28 20:05 ` Don Zickus [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-03 17:59 Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728200532.GP2581@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox