* [PATCH] watchdog: NUMA affine kthreads
@ 2011-07-28 16:44 Eric Dumazet
2011-07-28 20:05 ` Don Zickus
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2011-07-28 16:44 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Don Zickus, Peter Zijlstra
watchdog kthreads can use kthread_create_on_node() to NUMA affine their
stack and task_struct.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Don Zickus <dzickus@redhat.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/watchdog.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..14cabcd 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
/* create the watchdog thread */
if (!p) {
- p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
+ p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
+ "watchdog/%d", cpu);
if (IS_ERR(p)) {
printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
if (!err) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: NUMA affine kthreads
2011-07-28 16:44 [PATCH] watchdog: NUMA affine kthreads Eric Dumazet
@ 2011-07-28 20:05 ` Don Zickus
0 siblings, 0 replies; 3+ messages in thread
From: Don Zickus @ 2011-07-28 20:05 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Ingo Molnar, linux-kernel, Peter Zijlstra
On Thu, Jul 28, 2011 at 06:44:28PM +0200, Eric Dumazet wrote:
> watchdog kthreads can use kthread_create_on_node() to NUMA affine their
> stack and task_struct.
Looks good, I'll apply and test it.
Thanks.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Don Zickus <dzickus@redhat.com>
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> kernel/watchdog.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 36491cd..14cabcd 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
>
> /* create the watchdog thread */
> if (!p) {
> - p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
> + p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
> + "watchdog/%d", cpu);
> if (IS_ERR(p)) {
> printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
> if (!err) {
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] watchdog: NUMA affine kthreads
@ 2011-08-03 17:59 Don Zickus
0 siblings, 0 replies; 3+ messages in thread
From: Don Zickus @ 2011-08-03 17:59 UTC (permalink / raw)
To: LKML; +Cc: Andrew Morton, Ingo Molnar, Eric Dumazet, Don Zickus,
Peter Zijlstra
From: Eric Dumazet <eric.dumazet@gmail.com>
watchdog kthreads can use kthread_create_on_node() to NUMA affine their
stack and task_struct.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Don Zickus <dzickus@redhat.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
kernel/watchdog.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 36491cd..14cabcd 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -438,7 +438,8 @@ static int watchdog_enable(int cpu)
/* create the watchdog thread */
if (!p) {
- p = kthread_create(watchdog, (void *)(unsigned long)cpu, "watchdog/%d", cpu);
+ p = kthread_create_on_node(watchdog, NULL, cpu_to_node(cpu),
+ "watchdog/%d", cpu);
if (IS_ERR(p)) {
printk(KERN_ERR "softlockup watchdog for %i failed\n", cpu);
if (!err) {
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-03 18:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-28 16:44 [PATCH] watchdog: NUMA affine kthreads Eric Dumazet
2011-07-28 20:05 ` Don Zickus
-- strict thread matches above, loose matches on Subject: below --
2011-08-03 17:59 Don Zickus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox