From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Mike Waychison <mikew@google.com>
Subject: Re: [PATCH] efivars: fix warnings when CONFIG_PSTORE=n
Date: Tue, 2 Aug 2011 22:03:26 +0100 [thread overview]
Message-ID: <20110802210326.GA2606@srcf.ucam.org> (raw)
In-Reply-To: <4e3864a227625bd7d6@agluck-desktop.sc.intel.com>
On Tue, Aug 02, 2011 at 01:57:06PM -0700, Luck, Tony wrote:
> drivers/firmware/efivars.c:161: warning: ‘utf16_strlen’ defined but not used
> utf16_strlen() is only used inside CONFIG_PSTORE - put same #ifdef around the
> definition of the function too.
>
> drivers/firmware/efivars.c:602: warning: initialization from incompatible pointer type
> Between v1 and v2 of this patch series we decided to make the "part" number
> unsigned - but missed fixing the stub version of efi_pstore_write()
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-08-02 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 20:57 [PATCH] efivars: fix warnings when CONFIG_PSTORE=n Luck, Tony
2011-08-02 21:03 ` Matthew Garrett [this message]
2011-08-02 22:01 ` Mike Waychison
2011-08-02 21:05 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802210326.GA2606@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox