From: "H. Peter Anvin" <hpa@zytor.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Mike Waychison <mikew@google.com>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] efivars: fix warnings when CONFIG_PSTORE=n
Date: Tue, 02 Aug 2011 14:05:01 -0700 [thread overview]
Message-ID: <4E38667D.4000901@zytor.com> (raw)
In-Reply-To: <4e3864a227625bd7d6@agluck-desktop.sc.intel.com>
On 08/02/2011 01:57 PM, Luck, Tony wrote:
>
> +#ifdef CONFIG_PSTORE
> static unsigned long
> utf16_strlen(efi_char16_t *s)
> {
> return utf16_strnlen(s, ~0UL);
> }
> +#endif
>
Unless this is actually called via an indirect function pointer, it can
just be changed to "static inline", which shuts up the warning, too.
-hpa
prev parent reply other threads:[~2011-08-02 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 20:57 [PATCH] efivars: fix warnings when CONFIG_PSTORE=n Luck, Tony
2011-08-02 21:03 ` Matthew Garrett
2011-08-02 22:01 ` Mike Waychison
2011-08-02 21:05 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E38667D.4000901@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mjg@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox