From: Vasiliy Kulikov <segoon@openwall.com>
To: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Ben Hutchings <ben@decadent.org.uk>,
Christian Ohm <chr.ohm@gmx.net>, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: re: perf tools: Check $HOME/.perfconfig ownership
Date: Thu, 11 Aug 2011 23:50:34 +0400 [thread overview]
Message-ID: <20110811195033.GA17313@albatros> (raw)
Hi,
The commit 069e3725dd9be3b759a98e8c80ac5fc38b392b23 introduced a check
whether $HOME/.perfconfig file is owned by the user. Three comments here:
1) How other user may create a file in other user's home directory? If
we assume he may do it, the situation is bad without any perf :(
2) If we assume (1) is somehow possible (e.g. other user may manipulate
this file only), there is a race against file creation/deletion and stat.
3) .perfconfig can be a symlink, so stat(2) should be changed to
lstat(2).
Thanks,
--
Vasiliy
reply other threads:[~2011-08-11 19:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811195033.GA17313@albatros \
--to=segoon@openwall.com \
--cc=acme@redhat.com \
--cc=ben@decadent.org.uk \
--cc=chr.ohm@gmx.net \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox