public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* re: perf tools: Check $HOME/.perfconfig ownership
@ 2011-08-11 19:50 Vasiliy Kulikov
  0 siblings, 0 replies; only message in thread
From: Vasiliy Kulikov @ 2011-08-11 19:50 UTC (permalink / raw)
  To: linux-kernel, Arnaldo Carvalho de Melo
  Cc: Ingo Molnar, Ben Hutchings, Christian Ohm, David Ahern,
	Frederic Weisbecker, Jonathan Nieder, Mike Galbraith,
	Paul Mackerras, Peter Zijlstra, Stephane Eranian

Hi,

The commit 069e3725dd9be3b759a98e8c80ac5fc38b392b23 introduced a check
whether $HOME/.perfconfig file is owned by the user.  Three comments here:

1) How other user may create a file in other user's home directory?  If
we assume he may do it, the situation is bad without any perf :(

2) If we assume (1) is somehow possible (e.g. other user may manipulate
this file only), there is a race against file creation/deletion and stat.

3) .perfconfig can be a symlink, so stat(2) should be changed to
lstat(2).


Thanks,

-- 
Vasiliy

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2011-08-11 19:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 19:50 perf tools: Check $HOME/.perfconfig ownership Vasiliy Kulikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox