The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] leds: Remove obsolete cleanup for clientdata
@ 2011-08-25 10:48 Wolfram Sang
  2011-08-30 12:44 ` Jean Delvare
  0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2011-08-25 10:48 UTC (permalink / raw)
  To: linux-i2c; +Cc: Wolfram Sang, Richard Purdie, Andrew Morton, linux-kernel

A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 drivers/leds/leds-lm3530.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
index 3dd7090..d2d25e6 100644
--- a/drivers/leds/leds-lm3530.c
+++ b/drivers/leds/leds-lm3530.c
@@ -421,7 +421,6 @@ err_class_register:
 err_reg_init:
 	regulator_put(drvdata->regulator);
 err_regulator_get:
-	i2c_set_clientdata(client, NULL);
 	kfree(drvdata);
 err_out:
 	return err;
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] leds: Remove obsolete cleanup for clientdata
  2011-08-25 10:48 [PATCH] leds: Remove obsolete cleanup for clientdata Wolfram Sang
@ 2011-08-30 12:44 ` Jean Delvare
  0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2011-08-30 12:44 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-i2c, Richard Purdie, Andrew Morton, linux-kernel

On Thu, 25 Aug 2011 12:48:25 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
>  drivers/leds/leds-lm3530.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
> index 3dd7090..d2d25e6 100644
> --- a/drivers/leds/leds-lm3530.c
> +++ b/drivers/leds/leds-lm3530.c
> @@ -421,7 +421,6 @@ err_class_register:
>  err_reg_init:
>  	regulator_put(drvdata->regulator);
>  err_regulator_get:
> -	i2c_set_clientdata(client, NULL);
>  	kfree(drvdata);
>  err_out:
>  	return err;

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-30 12:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-25 10:48 [PATCH] leds: Remove obsolete cleanup for clientdata Wolfram Sang
2011-08-30 12:44 ` Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox