[PATCH 03/23] mfd/db8500-prcmu: initialize DB8500 PRCMU regs

[PATCH 03/23] mfd/db8500-prcmu: initialize DB8500 PRCMU regs

[Linus Walleij]

From: Mattias Nilsson <mattias.i.nilsson@stericsson.com>

Some clocks may be force enabled when we probe the
driver, but they need to be turned off by default so
we have a known state. We call this the register
initialization function if we need more stuff in
there in the future.

Signed-off-by: Mattias Nilsson <mattias.i.nilsson@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mfd/db8500-prcmu.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index dcc690e..e2c4a26 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -1840,6 +1840,16 @@ void __init prcmu_early_init(void)
 	}
 }
 
+static void __init init_prcm_registers(void)
+{
+	u32 val;
+
+	val = readl(PRCM_A9PL_FORCE_CLKEN);
+	val &= ~(PRCM_A9PL_FORCE_CLKEN_PRCM_A9PL_FORCE_CLKEN |
+		PRCM_A9PL_FORCE_CLKEN_PRCM_A9AXI_FORCE_CLKEN);
+	writel(val, (PRCM_A9PL_FORCE_CLKEN));
+}
+
 /*
  * Power domain switches (ePODs) modeled as regulators for the DB8500 SoC
  */
@@ -2038,6 +2048,8 @@ static int __init db8500_prcmu_probe(struct platform_device *pdev)
 	if (ux500_is_svp())
 		return -ENODEV;
 
+	init_prcm_registers();
+
 	/* Clean up the mailbox interrupts after pre-kernel code. */
 	writel(ALL_MBOX_BITS, PRCM_ARM_IT1_CLR);
 
-- 
1.7.3.2

Re: [PATCH 03/23] mfd/db8500-prcmu: initialize DB8500 PRCMU regs

[Samuel Ortiz]

Hi Linus,

On Fri, Aug 12, 2011 at 10:27:50AM +0200, Linus Walleij wrote:
> From: Mattias Nilsson <mattias.i.nilsson@stericsson.com>
> 
> Some clocks may be force enabled when we probe the
> driver, but they need to be turned off by default so
> we have a known state. We call this the register
> initialization function if we need more stuff in
> there in the future.
> 
> Signed-off-by: Mattias Nilsson <mattias.i.nilsson@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/db8500-prcmu.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index dcc690e..e2c4a26 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -1840,6 +1840,16 @@ void __init prcmu_early_init(void)
>  	}
>  }
>  
> +static void __init init_prcm_registers(void)
Could we have a less generic function name here ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [PATCH 03/23] mfd/db8500-prcmu: initialize DB8500 PRCMU regs

[Linus Walleij]

On Mon, Oct 3, 2011 at 5:51 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:

>> +static void __init init_prcm_registers(void)
> Could we have a less generic function name here ?

OK I will rename it db8500_prcmu_init() as an add-on patch.

Yours,
Linus Walleij