* [PATCH 4/4] staging: et131x: Update TODO list @ 2011-10-10 15:22 Mark Einon 2011-10-11 14:53 ` Nick Bowler 2011-10-11 16:00 ` Ramesh R 0 siblings, 2 replies; 11+ messages in thread From: Mark Einon @ 2011-10-10 15:22 UTC (permalink / raw) To: gregkh; +Cc: devel, linux-kernel, Mark Einon Added some more tasks to the TODO list, as highlighted by Francois Romieu <romieu@fr.zoreil.com>. Signed-off-by: Mark Einon <mark.einon@gmail.com> --- drivers/staging/et131x/README | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index d383e80..c67f83e 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. Based on the driver found at https://sourceforge.net/projects/et131x/ -Cleaned up immensely by Olaf Hartman and Christoph -Hellwig <hch@infradead.org> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org> Note, the powermanagement options were removed from the vendor provided driver as they did not build properly at the time. TODO: + - Put the driver into a single file, with a .h for the registers layout. + - rx_ring.fbr{0, 1} can probably share a common structure + - Use of kmem_cache seems a bit unusual + - Use dma_alloc_... in place of pci_alloc_... + - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet. + - PCI_VDEVICE ? Please send patches to: Greg Kroah-Hartman <gregkh@suse.de> -- 1.7.6.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-10 15:22 [PATCH 4/4] staging: et131x: Update TODO list Mark Einon @ 2011-10-11 14:53 ` Nick Bowler 2011-10-11 15:47 ` Mark Einon 2011-10-11 16:00 ` Ramesh R 1 sibling, 1 reply; 11+ messages in thread From: Nick Bowler @ 2011-10-11 14:53 UTC (permalink / raw) To: Mark Einon; +Cc: gregkh, devel, linux-kernel Hi Mark, On 2011-10-10 16:22 +0100, Mark Einon wrote: > diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README > index d383e80..c67f83e 100644 > --- a/drivers/staging/et131x/README > +++ b/drivers/staging/et131x/README > @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. > > Based on the driver found at https://sourceforge.net/projects/et131x/ > > -Cleaned up immensely by Olaf Hartman and Christoph > -Hellwig <hch@infradead.org> > +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org> It seems that a fragment from your earlier patch, "staging: et131x: Removing Olaf Hartmann's email as it bounces", got mixed up with this one. Cheers, -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 14:53 ` Nick Bowler @ 2011-10-11 15:47 ` Mark Einon 2011-10-11 16:07 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Mark Einon @ 2011-10-11 15:47 UTC (permalink / raw) To: Nick Bowler; +Cc: gregkh, devel, linux-kernel On 11 October 2011 15:53, Nick Bowler <nbowler@elliptictech.com> wrote: > Hi Mark, > > On 2011-10-10 16:22 +0100, Mark Einon wrote: >> diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README >> index d383e80..c67f83e 100644 >> --- a/drivers/staging/et131x/README >> +++ b/drivers/staging/et131x/README >> @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. >> >> Based on the driver found at https://sourceforge.net/projects/et131x/ >> >> -Cleaned up immensely by Olaf Hartman and Christoph >> -Hellwig <hch@infradead.org> >> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org> > > It seems that a fragment from your earlier patch, "staging: et131x: > Removing Olaf Hartmann's email as it bounces", got mixed up with this > one. Hi Nick, Well spotted! Actually, I was just sneaking in the removal of a carriage return which I didn't do in the earlier patch. I didn't think that anyone would mind, being in an unnoticeable README file in the staging directory of a staging-next tree - inhabiting a small, insignificant blue green planet, circling a star we call the Sun, in an unfashionable outer spiral arm of a galaxy known as the Milky Way. Let me know if its a problem. Best regards, Mark ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 15:47 ` Mark Einon @ 2011-10-11 16:07 ` Greg KH 0 siblings, 0 replies; 11+ messages in thread From: Greg KH @ 2011-10-11 16:07 UTC (permalink / raw) To: Mark Einon; +Cc: Nick Bowler, gregkh, devel, linux-kernel On Tue, Oct 11, 2011 at 04:47:57PM +0100, Mark Einon wrote: > On 11 October 2011 15:53, Nick Bowler <nbowler@elliptictech.com> wrote: > > Hi Mark, > > > > On 2011-10-10 16:22 +0100, Mark Einon wrote: > >> diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README > >> index d383e80..c67f83e 100644 > >> --- a/drivers/staging/et131x/README > >> +++ b/drivers/staging/et131x/README > >> @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. > >> > >> Based on the driver found at https://sourceforge.net/projects/et131x/ > >> > >> -Cleaned up immensely by Olaf Hartman and Christoph > >> -Hellwig <hch@infradead.org> > >> +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org> > > > > It seems that a fragment from your earlier patch, "staging: et131x: > > Removing Olaf Hartmann's email as it bounces", got mixed up with this > > one. > > Hi Nick, > > Well spotted! > > Actually, I was just sneaking in the removal of a carriage return > which I didn't do in the earlier patch. > > I didn't think that anyone would mind, being in an unnoticeable README > file in the staging directory of a staging-next tree - inhabiting a > small, insignificant blue green planet, circling a star we call the > Sun, in an unfashionable outer spiral arm of a galaxy known as the > Milky Way. > > Let me know if its a problem. It's really not for something like this, I'll take it as-is. greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-10 15:22 [PATCH 4/4] staging: et131x: Update TODO list Mark Einon 2011-10-11 14:53 ` Nick Bowler @ 2011-10-11 16:00 ` Ramesh R 2011-10-11 16:11 ` Greg KH 1 sibling, 1 reply; 11+ messages in thread From: Ramesh R @ 2011-10-11 16:00 UTC (permalink / raw) To: Mark Einon; +Cc: gregkh, devel, linux-kernel Hi Mark, I wish to contribute to this project - From the latest TODO list in the README document drivers/staging/et131x/README If I were to start with the coding style cleanups, is there a coding standard available for reference? Please advice. Thanks Ramesh On Mon, Oct 10, 2011 at 8:22 AM, Mark Einon <mark.einon@gmail.com> wrote: > Added some more tasks to the TODO list, as highlighted by Francois > Romieu <romieu@fr.zoreil.com>. > > Signed-off-by: Mark Einon <mark.einon@gmail.com> > --- > drivers/staging/et131x/README | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README > index d383e80..c67f83e 100644 > --- a/drivers/staging/et131x/README > +++ b/drivers/staging/et131x/README > @@ -2,13 +2,18 @@ This is a driver for the ET1310 network device. > > Based on the driver found at https://sourceforge.net/projects/et131x/ > > -Cleaned up immensely by Olaf Hartman and Christoph > -Hellwig <hch@infradead.org> > +Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org> > > Note, the powermanagement options were removed from the vendor provided > driver as they did not build properly at the time. > > TODO: > + - Put the driver into a single file, with a .h for the registers layout. > + - rx_ring.fbr{0, 1} can probably share a common structure > + - Use of kmem_cache seems a bit unusual > + - Use dma_alloc_... in place of pci_alloc_... > + - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet. > + - PCI_VDEVICE ? > > Please send patches to: > Greg Kroah-Hartman <gregkh@suse.de> > -- > 1.7.6.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 16:00 ` Ramesh R @ 2011-10-11 16:11 ` Greg KH 2011-10-11 16:25 ` Mark Einon 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2011-10-11 16:11 UTC (permalink / raw) To: Ramesh R; +Cc: Mark Einon, devel, linux-kernel On Tue, Oct 11, 2011 at 09:00:35AM -0700, Ramesh R wrote: > Hi Mark, > > I wish to contribute to this project - From the latest TODO list in > the README document > > drivers/staging/et131x/README > > If I were to start with the coding style cleanups, is there a coding > standard available for reference? Please advice. Documentation/CodingStyle ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 16:11 ` Greg KH @ 2011-10-11 16:25 ` Mark Einon 2011-10-11 17:25 ` Ramesh R 0 siblings, 1 reply; 11+ messages in thread From: Mark Einon @ 2011-10-11 16:25 UTC (permalink / raw) To: Greg KH; +Cc: Ramesh R, devel, linux-kernel On 11 October 2011 17:11, Greg KH <gregkh@suse.de> wrote: > On Tue, Oct 11, 2011 at 09:00:35AM -0700, Ramesh R wrote: >> Hi Mark, >> >> I wish to contribute to this project - From the latest TODO list in >> the README document >> >> drivers/staging/et131x/README >> >> If I were to start with the coding style cleanups, is there a coding >> standard available for reference? Please advice. > > Documentation/CodingStyle > Ramesh, There are no significant coding style issues with this particular driver at this time, as far as I (and the checkpatch script) are aware of. I suggest you check other staging/ drivers for these sorts of issues. Cheers, Mark ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 16:25 ` Mark Einon @ 2011-10-11 17:25 ` Ramesh R 2011-10-11 18:40 ` Denis Kirjanov 0 siblings, 1 reply; 11+ messages in thread From: Ramesh R @ 2011-10-11 17:25 UTC (permalink / raw) To: Mark Einon; +Cc: Greg KH, devel, linux-kernel Thanks Mark, Are there any open items left in the TODO list for this driver at this point? Regards Ramesh On Tue, Oct 11, 2011 at 9:25 AM, Mark Einon <mark.einon@gmail.com> wrote: > On 11 October 2011 17:11, Greg KH <gregkh@suse.de> wrote: >> On Tue, Oct 11, 2011 at 09:00:35AM -0700, Ramesh R wrote: >>> Hi Mark, >>> >>> I wish to contribute to this project - From the latest TODO list in >>> the README document >>> >>> drivers/staging/et131x/README >>> >>> If I were to start with the coding style cleanups, is there a coding >>> standard available for reference? Please advice. >> >> Documentation/CodingStyle >> > Ramesh, > > There are no significant coding style issues with this particular > driver at this time, as far as I (and the checkpatch script) are aware > of. > I suggest you check other staging/ drivers for these sorts of issues. > > Cheers, > > Mark > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 17:25 ` Ramesh R @ 2011-10-11 18:40 ` Denis Kirjanov 2011-10-12 2:37 ` Ramesh R 0 siblings, 1 reply; 11+ messages in thread From: Denis Kirjanov @ 2011-10-11 18:40 UTC (permalink / raw) To: Ramesh R; +Cc: Mark Einon, devel, Greg KH, linux-kernel If you look at the patch once again then you find some On Tue, Oct 11, 2011 at 9:25 PM, Ramesh R <rshlinux@gmail.com> wrote: > Thanks Mark, > > Are there any open items left in the TODO list for this driver at this point? > > Regards > Ramesh > > On Tue, Oct 11, 2011 at 9:25 AM, Mark Einon <mark.einon@gmail.com> wrote: >> On 11 October 2011 17:11, Greg KH <gregkh@suse.de> wrote: >>> On Tue, Oct 11, 2011 at 09:00:35AM -0700, Ramesh R wrote: >>>> Hi Mark, >>>> >>>> I wish to contribute to this project - From the latest TODO list in >>>> the README document >>>> >>>> drivers/staging/et131x/README >>>> >>>> If I were to start with the coding style cleanups, is there a coding >>>> standard available for reference? Please advice. >>> >>> Documentation/CodingStyle >>> >> Ramesh, >> >> There are no significant coding style issues with this particular >> driver at this time, as far as I (and the checkpatch script) are aware >> of. >> I suggest you check other staging/ drivers for these sorts of issues. >> >> Cheers, >> >> Mark >> > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel > -- Regards, Denis ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-11 18:40 ` Denis Kirjanov @ 2011-10-12 2:37 ` Ramesh R 2011-10-12 9:10 ` Mark Einon 0 siblings, 1 reply; 11+ messages in thread From: Ramesh R @ 2011-10-12 2:37 UTC (permalink / raw) To: Denis Kirjanov; +Cc: Mark Einon, devel, linux-kernel On Tue, Oct 11, 2011 at 11:40 AM, Denis Kirjanov <kirjanov@gmail.com> wrote: > If you look at the patch once again then you find some > > On Tue, Oct 11, 2011 at 9:25 PM, Ramesh R <rshlinux@gmail.com> wrote: >> Thanks Mark, >> >> Are there any open items left in the TODO list for this driver at this point? >> >> Regards >> Ramesh >> >> On Tue, Oct 11, 2011 at 9:25 AM, Mark Einon <mark.einon@gmail.com> wrote: >>> On 11 October 2011 17:11, Greg KH <gregkh@suse.de> wrote: >>>> On Tue, Oct 11, 2011 at 09:00:35AM -0700, Ramesh R wrote: >>>>> Hi Mark, >>>>> >>>>> I wish to contribute to this project - From the latest TODO list in >>>>> the README document >>>>> >>>>> drivers/staging/et131x/README >>>>> >>>>> If I were to start with the coding style cleanups, is there a coding >>>>> standard available for reference? Please advice. >>>> >>>> Documentation/CodingStyle >>>> >>> Ramesh, >>> >>> There are no significant coding style issues with this particular >>> driver at this time, as far as I (and the checkpatch script) are aware >>> of. >>> I suggest you check other staging/ drivers for these sorts of issues. >>> >>> Cheers, >>> >>> Mark >>> >> _______________________________________________ >> devel mailing list >> devel@linuxdriverproject.org >> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel >> Thank you, got a few items. I could work on item #1, == TODO: + - Put the driver into a single file, with a .h for the registers layout. + - rx_ring.fbr{0, 1} can probably share a common structure + - Use of kmem_cache seems a bit unusual + - Use dma_alloc_... in place of pci_alloc_... + - It's too late stopping the tx queue when there is no room for the current packet. The condition should be detected for the next packet. + - PCI_VDEVICE ? == I looked up for ET 1310 on ebay, amazon & few other sites like digikey - I couldnt find the device. Can you please let me know where I can buy the hardware? /Ramesh ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/4] staging: et131x: Update TODO list 2011-10-12 2:37 ` Ramesh R @ 2011-10-12 9:10 ` Mark Einon 0 siblings, 0 replies; 11+ messages in thread From: Mark Einon @ 2011-10-12 9:10 UTC (permalink / raw) To: Ramesh R; +Cc: Denis Kirjanov, devel, linux-kernel On 12 October 2011 03:37, Ramesh R <rshlinux@gmail.com> wrote: > I could work on item #1, Actually, I have some patches for that ready to post this evening. Any other item is good, however. > == > TODO: > + - Put the driver into a single file, with a .h for the registers layout. > + - rx_ring.fbr{0, 1} can probably share a common structure > + - Use of kmem_cache seems a bit unusual > + - Use dma_alloc_... in place of pci_alloc_... > + - It's too late stopping the tx queue when there is no room > for the current packet. The condition should be detected for the next > packet. > + - PCI_VDEVICE ? > > == > > I looked up for ET 1310 on ebay, amazon & few other sites like digikey > - I couldnt find the device. Can you please let me know where I can > buy the hardware? I'm afraid I can't be of much help with that - its quite hard to get hold of. I believe the chip is a few years old, not made anymore and was not widely sold when it was. I managed to get hold of a card from eBay via a seller in France. Mark ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-10-12 9:10 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-10-10 15:22 [PATCH 4/4] staging: et131x: Update TODO list Mark Einon 2011-10-11 14:53 ` Nick Bowler 2011-10-11 15:47 ` Mark Einon 2011-10-11 16:07 ` Greg KH 2011-10-11 16:00 ` Ramesh R 2011-10-11 16:11 ` Greg KH 2011-10-11 16:25 ` Mark Einon 2011-10-11 17:25 ` Ramesh R 2011-10-11 18:40 ` Denis Kirjanov 2011-10-12 2:37 ` Ramesh R 2011-10-12 9:10 ` Mark Einon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox