* [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless
@ 2011-11-17 22:43 Thomas Meyer
2011-11-18 10:16 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Meyer @ 2011-11-17 22:43 UTC (permalink / raw)
To: tglx, mingo, hpa, x86, linux-kernel
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
--- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
+++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
@@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
pentry = (struct sfi_gpio_table_entry *)sb->pentry;
- gpio_table = (struct sfi_gpio_table_entry *)
+ gpio_table =
kmalloc(num * sizeof(*pentry), GFP_KERNEL);
if (!gpio_table)
return -1;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless
2011-11-17 22:43 [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless Thomas Meyer
@ 2011-11-18 10:16 ` Alan Cox
2011-11-18 13:40 ` Pekka Enberg
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2011-11-18 10:16 UTC (permalink / raw)
To: Thomas Meyer; +Cc: tglx, mingo, hpa, x86, linux-kernel
On Thu, 17 Nov 2011 23:43:40 +0100
Thomas Meyer <thomas@m3y3r.de> wrote:
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
> num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
> pentry = (struct sfi_gpio_table_entry *)sb->pentry;
>
> - gpio_table = (struct sfi_gpio_table_entry *)
> + gpio_table =
> kmalloc(num * sizeof(*pentry), GFP_KERNEL);
True but the formatting also wants fixing with that change.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless
2011-11-18 10:16 ` Alan Cox
@ 2011-11-18 13:40 ` Pekka Enberg
2011-11-20 22:28 ` David Rientjes
0 siblings, 1 reply; 4+ messages in thread
From: Pekka Enberg @ 2011-11-18 13:40 UTC (permalink / raw)
To: Alan Cox; +Cc: Thomas Meyer, tglx, mingo, hpa, x86, linux-kernel
> On Thu, 17 Nov 2011 23:43:40 +0100
> Thomas Meyer <thomas@m3y3r.de> wrote:
>
>> The semantic patch that makes this change is available
>> in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
>>
>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>> ---
>>
>> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
>> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
>> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
>> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
>> num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
>> pentry = (struct sfi_gpio_table_entry *)sb->pentry;
>>
>> - gpio_table = (struct sfi_gpio_table_entry *)
>> + gpio_table =
>> kmalloc(num * sizeof(*pentry), GFP_KERNEL);
On Fri, Nov 18, 2011 at 12:16 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> True but the formatting also wants fixing with that change.
A conversion to kcalloc() would make sense as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless
2011-11-18 13:40 ` Pekka Enberg
@ 2011-11-20 22:28 ` David Rientjes
0 siblings, 0 replies; 4+ messages in thread
From: David Rientjes @ 2011-11-20 22:28 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Alan Cox, Thomas Meyer, tglx, mingo, hpa, x86, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 937 bytes --]
On Fri, 18 Nov 2011, Pekka Enberg wrote:
> >> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
> >> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
> >> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
> >> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
> >> num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
> >> pentry = (struct sfi_gpio_table_entry *)sb->pentry;
> >>
> >> - gpio_table = (struct sfi_gpio_table_entry *)
> >> + gpio_table =
> >> kmalloc(num * sizeof(*pentry), GFP_KERNEL);
>
> On Fri, Nov 18, 2011 at 12:16 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > True but the formatting also wants fixing with that change.
>
> A conversion to kcalloc() would make sense as well.
Seems unnecessary to zero the array if it's going to immediately copy the
gpio table, though.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-20 22:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 22:43 [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless Thomas Meyer
2011-11-18 10:16 ` Alan Cox
2011-11-18 13:40 ` Pekka Enberg
2011-11-20 22:28 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox