public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Add Thinkpad SL510 to pci=nocrs blacklist
@ 2012-01-04 16:30 Dave Jones
  2012-01-04 17:10 ` Jesse Barnes
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2012-01-04 16:30 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: Jesse Barnes, Ingo Molnar, Linux Kernel, x86

Enabling CRS by default breaks suspend on the Thinkpad SL510.
Details in https://bugzilla.redhat.com/show_bug.cgi?id=769657

Reported-by: Stefan Kirrmann <stefan.kirrmann@gmail.com>
Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-3.1.noarch/arch/x86/pci/acpi.c~	2011-12-30 14:42:43.495717907 -0500
+++ linux-3.1.noarch/arch/x86/pci/acpi.c	2011-12-30 14:45:09.296198024 -0500
@@ -72,6 +72,16 @@ static const struct dmi_system_id pci_us
 			DMI_MATCH(DMI_BOARD_NAME, "0M273C"),
 		},
 	},
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
+	{
+		.callback = set_nouse_crs,
+		.ident = "Thinkpad SL510",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_BOARD_NAME, "2847DFG"),
+			DMI_MATCH(DMI_BIOS_VERSION, "6JET85WW (1.43 )"),
+		},
+	},
 	{}
 };
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Add Thinkpad SL510 to pci=nocrs blacklist
  2012-01-04 16:30 Add Thinkpad SL510 to pci=nocrs blacklist Dave Jones
@ 2012-01-04 17:10 ` Jesse Barnes
  2012-01-11 16:08   ` Bjorn Helgaas
  0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2012-01-04 17:10 UTC (permalink / raw)
  To: Dave Jones; +Cc: Bjorn Helgaas, Ingo Molnar, Linux Kernel, x86

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Wed, 4 Jan 2012 11:30:52 -0500
Dave Jones <davej@redhat.com> wrote:

> Enabling CRS by default breaks suspend on the Thinkpad SL510.
> Details in https://bugzilla.redhat.com/show_bug.cgi?id=769657
> 
> Reported-by: Stefan Kirrmann <stefan.kirrmann@gmail.com>
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- linux-3.1.noarch/arch/x86/pci/acpi.c~	2011-12-30 14:42:43.495717907 -0500
> +++ linux-3.1.noarch/arch/x86/pci/acpi.c	2011-12-30 14:45:09.296198024 -0500
> @@ -72,6 +72,16 @@ static const struct dmi_system_id pci_us
>  			DMI_MATCH(DMI_BOARD_NAME, "0M273C"),
>  		},
>  	},
> +	/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
> +	{
> +		.callback = set_nouse_crs,
> +		.ident = "Thinkpad SL510",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_BOARD_NAME, "2847DFG"),
> +			DMI_MATCH(DMI_BIOS_VERSION, "6JET85WW (1.43 )"),
> +		},
> +	},
>  	{}
>  };
>  
> 
> 

Ah I see the Thinkpad patch now... applied this one too.   Thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Add Thinkpad SL510 to pci=nocrs blacklist
  2012-01-04 17:10 ` Jesse Barnes
@ 2012-01-11 16:08   ` Bjorn Helgaas
  0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2012-01-11 16:08 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: Dave Jones, Ingo Molnar, Linux Kernel, x86, linux-pci

On Wed, Jan 4, 2012 at 10:10 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Wed, 4 Jan 2012 11:30:52 -0500
> Dave Jones <davej@redhat.com> wrote:
>
>> Enabling CRS by default breaks suspend on the Thinkpad SL510.
>> Details in https://bugzilla.redhat.com/show_bug.cgi?id=769657
>>
>> Reported-by: Stefan Kirrmann <stefan.kirrmann@gmail.com>
>> Signed-off-by: Dave Jones <davej@redhat.com>
>>
>> --- linux-3.1.noarch/arch/x86/pci/acpi.c~     2011-12-30 14:42:43.495717907 -0500
>> +++ linux-3.1.noarch/arch/x86/pci/acpi.c      2011-12-30 14:45:09.296198024 -0500
>> @@ -72,6 +72,16 @@ static const struct dmi_system_id pci_us
>>                       DMI_MATCH(DMI_BOARD_NAME, "0M273C"),
>>               },
>>       },
>> +     /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
>> +     {
>> +             .callback = set_nouse_crs,
>> +             .ident = "Thinkpad SL510",
>> +             .matches = {
>> +                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> +                     DMI_MATCH(DMI_BOARD_NAME, "2847DFG"),
>> +                     DMI_MATCH(DMI_BIOS_VERSION, "6JET85WW (1.43 )"),
>> +             },
>> +     },
>>       {}
>>  };
>>
>>
>>
>
> Ah I see the Thinkpad patch now... applied this one too.   Thanks.

+linux-pci

I think we should hold off on this one, too.  We (at least I) don't
understand the root cause here.

Bjorn

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-11 16:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 16:30 Add Thinkpad SL510 to pci=nocrs blacklist Dave Jones
2012-01-04 17:10 ` Jesse Barnes
2012-01-11 16:08   ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox