* Re: [PATCH] max8997_charger: Remove duplicate module.h
@ 2011-11-23 11:26 MyungJoo Ham
2011-11-25 23:34 ` Anton Vorontsov
2012-01-06 0:59 ` Anton Vorontsov
0 siblings, 2 replies; 4+ messages in thread
From: MyungJoo Ham @ 2011-11-23 11:26 UTC (permalink / raw)
To: 최종환, linux-kernel@vger.kernel.org; +Cc: Anton Vorontsov
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1015 bytes --]
Sender : ÃÖÁ¾È¯<jhbird.choi@samsung.com> S4(¼±ÀÓ)/¼±ÀÓ/S/W Solution°³¹ßÆÀ(S.LSI)/»ï¼ºÀüÀÚ
Date : 2011-11-23 13:40 (GMT+09:00)
Title : [PATCH] max8997_charger: Remove duplicate module.h
>
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> module.h was included twice.
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/power/max8997_charger.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/max8997_charger.c b/drivers/power/max8997_charger.c
> index a23317d..ffc5033 100644
> --- a/drivers/power/max8997_charger.c
> +++ b/drivers/power/max8997_charger.c
> @@ -19,7 +19,6 @@
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
>
> -#include
> #include
> #include
> #include
> --
> 1.7.1
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] max8997_charger: Remove duplicate module.h
2011-11-23 11:26 [PATCH] max8997_charger: Remove duplicate module.h MyungJoo Ham
@ 2011-11-25 23:34 ` Anton Vorontsov
2012-01-06 0:59 ` Anton Vorontsov
1 sibling, 0 replies; 4+ messages in thread
From: Anton Vorontsov @ 2011-11-25 23:34 UTC (permalink / raw)
To: MyungJoo Ham; +Cc: 최종환, linux-kernel@vger.kernel.org
On Wed, Nov 23, 2011 at 11:26:41AM +0000, MyungJoo Ham wrote:
> Sender : 최종환<jhbird.choi@samsung.com> S4(선임)/선임/S/W Solution개발팀(S.LSI)/삼성전자
> Date : 2011-11-23 13:40 (GMT+09:00)
> Title : [PATCH] max8997_charger: Remove duplicate module.h
> >
> > From: Jonghwan Choi <jhbird.choi@samsung.com>
> >
> > module.h was included twice.
> >
> > Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
The issue introduced in post-3.1 kernels, and since I don't want
to send it to Linus now (as it is not a regression fix), nor I want
to pull -rc kernels into battery GIT tree, I'll just let the patch
sit for awhile till 3.2 released. And during merge window I'll apply
it, just before sending pull request.
That is, I noticed the patch, it looks OK, and I'll apply it. Just
not now.
Thanks!
p.s.
The other option you have is to send the patch via -trivial tree.
I'm fine either way.
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] max8997_charger: Remove duplicate module.h
2011-11-23 11:26 [PATCH] max8997_charger: Remove duplicate module.h MyungJoo Ham
2011-11-25 23:34 ` Anton Vorontsov
@ 2012-01-06 0:59 ` Anton Vorontsov
1 sibling, 0 replies; 4+ messages in thread
From: Anton Vorontsov @ 2012-01-06 0:59 UTC (permalink / raw)
To: MyungJoo Ham; +Cc: 최종환, linux-kernel@vger.kernel.org
On Wed, Nov 23, 2011 at 11:26:41AM +0000, MyungJoo Ham wrote:
> Sender : 최종환<jhbird.choi@samsung.com> S4(선임)/선임/S/W Solution개발팀(S.LSI)/삼성전자
> Date : 2011-11-23 13:40 (GMT+09:00)
> Title : [PATCH] max8997_charger: Remove duplicate module.h
> >
> > From: Jonghwan Choi <jhbird.choi@samsung.com>
> >
> > module.h was included twice.
> >
> > Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Applied, thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] max8997_charger: Remove duplicate module.h
@ 2011-11-23 4:40 jhbird.choi
0 siblings, 0 replies; 4+ messages in thread
From: jhbird.choi @ 2011-11-23 4:40 UTC (permalink / raw)
To: linux-kernel; +Cc: MyungJoo Ham, Anton Vorontsov, Jonghwan Choi
From: Jonghwan Choi <jhbird.choi@samsung.com>
module.h was included twice.
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/power/max8997_charger.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/power/max8997_charger.c b/drivers/power/max8997_charger.c
index a23317d..ffc5033 100644
--- a/drivers/power/max8997_charger.c
+++ b/drivers/power/max8997_charger.c
@@ -19,7 +19,6 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
-#include <linux/module.h>
#include <linux/err.h>
#include <linux/module.h>
#include <linux/slab.h>
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-06 0:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23 11:26 [PATCH] max8997_charger: Remove duplicate module.h MyungJoo Ham
2011-11-25 23:34 ` Anton Vorontsov
2012-01-06 0:59 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2011-11-23 4:40 jhbird.choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox