[PATCH] mfd: Still check other interrupts if we get a wm831x touchscreen IRQ

[PATCH] mfd: Still check other interrupts if we get a wm831x touchscreen IRQ

[Mark Brown]

It is possible that we will see another interrupt triggering at the same
time as the touchscreen interrupts so it's still worth checking other
possible sources. Almost all of the win from the fast path comes from only
needing to read the primary register and saving the I/O costs.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/mfd/wm831x-irq.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/wm831x-irq.c b/drivers/mfd/wm831x-irq.c
index 7be5f09..bec4d05 100644
--- a/drivers/mfd/wm831x-irq.c
+++ b/drivers/mfd/wm831x-irq.c
@@ -472,8 +472,7 @@ static irqreturn_t wm831x_irq_thread(int irq, void *data)
 		handle_nested_irq(wm831x->irq_base + WM831X_IRQ_TCHPD);
 	if (primary & WM831X_TCHDATA_INT)
 		handle_nested_irq(wm831x->irq_base + WM831X_IRQ_TCHDATA);
-	if (primary & (WM831X_TCHDATA_EINT | WM831X_TCHPD_EINT))
-		goto out;
+	primary &= ~(WM831X_TCHDATA_EINT | WM831X_TCHPD_EINT);
 
 	for (i = 0; i < ARRAY_SIZE(wm831x_irqs); i++) {
 		int offset = wm831x_irqs[i].reg - 1;
-- 
1.7.7.3

Re: [PATCH] mfd: Still check other interrupts if we get a wm831x touchscreen IRQ

[Samuel Ortiz]

Hi Mark,

On Tue, Dec 27, 2011 at 05:20:10PM +0000, Mark Brown wrote:
> It is possible that we will see another interrupt triggering at the same
> time as the touchscreen interrupts so it's still worth checking other
> possible sources. Almost all of the win from the fast path comes from only
> needing to read the primary register and saving the I/O costs.
Thanks, applied.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/