The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] usb: xhci: fix section mismatch in linux-next
@ 2012-03-16 18:34 Gerard Snitselaar
  2012-03-16 21:05 ` Sarah Sharp
  0 siblings, 1 reply; 3+ messages in thread
From: Gerard Snitselaar @ 2012-03-16 18:34 UTC (permalink / raw)
  To: sarah.a.sharp; +Cc: gregkh, linux-usb, linux-kernel

xhci_unregister_pci() is called in xhci_hcd_init().

Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>
---
 drivers/usb/host/xhci-pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index ef98b38..0d7b851 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -326,7 +326,7 @@ int __init xhci_register_pci(void)
 	return pci_register_driver(&xhci_pci_driver);
 }
 
-void __exit xhci_unregister_pci(void)
+void xhci_unregister_pci(void)
 {
 	pci_unregister_driver(&xhci_pci_driver);
 }
-- 
1.7.7.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: xhci: fix section mismatch in linux-next
  2012-03-16 18:34 [PATCH] usb: xhci: fix section mismatch in linux-next Gerard Snitselaar
@ 2012-03-16 21:05 ` Sarah Sharp
  2012-03-17  3:25   ` Gerard Snitselaar
  0 siblings, 1 reply; 3+ messages in thread
From: Sarah Sharp @ 2012-03-16 21:05 UTC (permalink / raw)
  To: Gerard Snitselaar; +Cc: gregkh, linux-usb, linux-kernel

This looks fine.  Does it need to be applied to stable as well, or is this
just a "nice to have" that should be queued for 3.4?

Sarah Sharp

On Fri, Mar 16, 2012 at 11:34:11AM -0700, Gerard Snitselaar wrote:
> xhci_unregister_pci() is called in xhci_hcd_init().
> 
> Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>
> ---
>  drivers/usb/host/xhci-pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index ef98b38..0d7b851 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -326,7 +326,7 @@ int __init xhci_register_pci(void)
>  	return pci_register_driver(&xhci_pci_driver);
>  }
>  
> -void __exit xhci_unregister_pci(void)
> +void xhci_unregister_pci(void)
>  {
>  	pci_unregister_driver(&xhci_pci_driver);
>  }
> -- 
> 1.7.7.6
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: xhci: fix section mismatch in linux-next
  2012-03-16 21:05 ` Sarah Sharp
@ 2012-03-17  3:25   ` Gerard Snitselaar
  0 siblings, 0 replies; 3+ messages in thread
From: Gerard Snitselaar @ 2012-03-17  3:25 UTC (permalink / raw)
  To: Sarah Sharp; +Cc: gregkh, linux-usb, linux-kernel

On Fri, Mar 16, 2012 at 02:05:42PM -0700, Sarah Sharp wrote:
> This looks fine.  Does it need to be applied to stable as well, or is this
> just a "nice to have" that should be queued for 3.4?
> 
> Sarah Sharp
> 

Hi Sarah, it is only a problem in linux-next because that code path
was added to xhci_hcd_init() by 3429e91a which isn't in stable.

> On Fri, Mar 16, 2012 at 11:34:11AM -0700, Gerard Snitselaar wrote:
> > xhci_unregister_pci() is called in xhci_hcd_init().
> > 
> > Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>
> > ---
> >  drivers/usb/host/xhci-pci.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index ef98b38..0d7b851 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -326,7 +326,7 @@ int __init xhci_register_pci(void)
> >  	return pci_register_driver(&xhci_pci_driver);
> >  }
> >  
> > -void __exit xhci_unregister_pci(void)
> > +void xhci_unregister_pci(void)
> >  {
> >  	pci_unregister_driver(&xhci_pci_driver);
> >  }
> > -- 
> > 1.7.7.6
> > 

-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-17  3:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-16 18:34 [PATCH] usb: xhci: fix section mismatch in linux-next Gerard Snitselaar
2012-03-16 21:05 ` Sarah Sharp
2012-03-17  3:25   ` Gerard Snitselaar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox