From: Grant Likely <grant.likely@secretlab.ca>
To: H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Cc: linus.walleij@stericsson.com
Subject: Re: [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message
Date: Sat, 24 Mar 2012 17:07:36 +0000 [thread overview]
Message-ID: <20120324170736.285BC3E0A0E@localhost> (raw)
In-Reply-To: <201203211113.28122.hartleys@visionengravers.com>
On Wed, 21 Mar 2012 11:13:27 -0700, H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> Minor removal of an unused inline function and a useless pr_err message.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Linus Walleij <linus.walleij@stericsson.com>
Applied, thanks.
g.
> ---
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 4ca5642..776b772 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -12,8 +12,6 @@
> * published by the Free Software Foundation.
> */
>
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> @@ -65,11 +63,6 @@ static void ep93xx_gpio_update_int_params(unsigned port)
> EP93XX_GPIO_REG(int_en_register_offset[port]));
> }
>
> -static inline void ep93xx_gpio_int_mask(unsigned line)
> -{
> - gpio_int_unmasked[line >> 3] &= ~(1 << (line & 7));
> -}
> -
> static void ep93xx_gpio_int_debounce(unsigned int irq, bool enable)
> {
> int line = irq_to_gpio(irq);
> @@ -212,7 +205,6 @@ static int ep93xx_gpio_irq_type(struct irq_data *d, unsigned int type)
> handler = handle_edge_irq;
> break;
> default:
> - pr_err("failed to set irq type %d for gpio %d\n", type, gpio);
> return -EINVAL;
> }
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
prev parent reply other threads:[~2012-03-25 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 18:13 [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message H Hartley Sweeten
2012-03-24 17:07 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324170736.285BC3E0A0E@localhost \
--to=grant.likely@secretlab.ca \
--cc=hartleys@visionengravers.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox