* [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message
@ 2012-03-21 18:13 H Hartley Sweeten
2012-03-24 17:07 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2012-03-21 18:13 UTC (permalink / raw)
To: Linux Kernel; +Cc: grant.likely, linus.walleij
Minor removal of an unused inline function and a useless pr_err message.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Walleij <linus.walleij@stericsson.com>
---
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 4ca5642..776b772 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -12,8 +12,6 @@
* published by the Free Software Foundation.
*/
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
#include <linux/init.h>
#include <linux/module.h>
#include <linux/platform_device.h>
@@ -65,11 +63,6 @@ static void ep93xx_gpio_update_int_params(unsigned port)
EP93XX_GPIO_REG(int_en_register_offset[port]));
}
-static inline void ep93xx_gpio_int_mask(unsigned line)
-{
- gpio_int_unmasked[line >> 3] &= ~(1 << (line & 7));
-}
-
static void ep93xx_gpio_int_debounce(unsigned int irq, bool enable)
{
int line = irq_to_gpio(irq);
@@ -212,7 +205,6 @@ static int ep93xx_gpio_irq_type(struct irq_data *d, unsigned int type)
handler = handle_edge_irq;
break;
default:
- pr_err("failed to set irq type %d for gpio %d\n", type, gpio);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message
2012-03-21 18:13 [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message H Hartley Sweeten
@ 2012-03-24 17:07 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-03-24 17:07 UTC (permalink / raw)
To: H Hartley Sweeten, Linux Kernel; +Cc: linus.walleij
On Wed, 21 Mar 2012 11:13:27 -0700, H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> Minor removal of an unused inline function and a useless pr_err message.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Linus Walleij <linus.walleij@stericsson.com>
Applied, thanks.
g.
> ---
>
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 4ca5642..776b772 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -12,8 +12,6 @@
> * published by the Free Software Foundation.
> */
>
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> @@ -65,11 +63,6 @@ static void ep93xx_gpio_update_int_params(unsigned port)
> EP93XX_GPIO_REG(int_en_register_offset[port]));
> }
>
> -static inline void ep93xx_gpio_int_mask(unsigned line)
> -{
> - gpio_int_unmasked[line >> 3] &= ~(1 << (line & 7));
> -}
> -
> static void ep93xx_gpio_int_debounce(unsigned int irq, bool enable)
> {
> int line = irq_to_gpio(irq);
> @@ -212,7 +205,6 @@ static int ep93xx_gpio_irq_type(struct irq_data *d, unsigned int type)
> handler = handle_edge_irq;
> break;
> default:
> - pr_err("failed to set irq type %d for gpio %d\n", type, gpio);
> return -EINVAL;
> }
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-25 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-21 18:13 [PATCH] gpio: ep93xx: Remove unused inline function and useless pr_err message H Hartley Sweeten
2012-03-24 17:07 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox