From: Ingo Molnar <mingo@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Drake <dsd@laptop.org>,
mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
dilinger@queued.net, pgf@laptop.org
Subject: Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands
Date: Tue, 27 Mar 2012 01:14:08 +0200 [thread overview]
Message-ID: <20120326231408.GA7495@gmail.com> (raw)
In-Reply-To: <20120326142908.c5248aec.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> > Signed-off-by: Daniel Drake <dsd@laptop.org>
> > Originally-from: Paul Fox <pgf@laptop.org>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Andres Salomon <dilinger@queued.net>
> >
> > ...
> >
> > v4: really fix sign-off tags
>
> s/fix/break/? "Originally-from" is not a recognised tag. If this code
> is based upon an earlier version from Paul then Signed-off-by: is
> correct.
No, the original ordering was *not* correct:
From: Daniel Drake <dsd@laptop.org>
[...]
Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Paul Fox <pgf@laptop.org>
In the previous discussion we had I explained what the rules for
signoffs are. Let me quote Linus as well:
" The sign-off chain should be very simple: the first person
to sign off should be the author, and the last person to
sign off should be the committer. "
https://lkml.org/lkml/2012/3/22/489
This is not true for this patch, because the first signoff does
not match the 'From:' line (author).
Nor is the last signoff the committer - i.e. the person sending
me this patch to apply. Every maintainer along the route adds a
signoff to the tail if it's propagated via email, or does a
merge commit if it's a pull.
If Daniel sends me a patch he should be the last signoff. If he
authored the patch then he should also be the first (and, by
implication, only) signoff. Signed-off-by does not recognize
multiple authorship - that has to be written into the changelog,
added via another type of tag - either approach is fine to me.
What I cannot do is to apply patches that have visibly broken
signoff chains.
Thanks,
Ingo
next prev parent reply other threads:[~2012-03-26 23:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 18:07 [PATCH v4] x86, olpc: add debugfs interface for EC commands Daniel Drake
2012-03-26 21:29 ` Andrew Morton
2012-03-26 21:31 ` H. Peter Anvin
2012-03-26 21:51 ` Andrew Morton
2012-03-27 16:07 ` Matthew Garrett
2012-03-27 16:18 ` Valdis.Kletnieks
2012-03-26 22:13 ` Paul Fox
2012-03-26 22:45 ` Daniel Drake
2012-03-26 22:47 ` H. Peter Anvin
2012-03-26 23:05 ` Andrew Morton
2012-03-26 22:53 ` Andrew Morton
2012-03-26 23:57 ` Andres Salomon
2012-03-26 23:14 ` Ingo Molnar [this message]
2012-03-26 23:23 ` Andrew Morton
2012-03-26 23:49 ` Ingo Molnar
2012-03-27 4:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326231408.GA7495@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pgf@laptop.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox