[PATCH 1/1] usb: Kconfig fix display

[PATCH 1/1] usb: Kconfig fix display

[Jean-Christophe PLAGNIOL-VILLARD]

Move HAS option before menuconfig so the USB option will show in the sub menu
and not the drivers menu.
Introduce in commit 53c6bc24fdc8db87109a5760579cbb060fa644cf usb: Don't make
USB_ARCH_HAS_{XHCI,OHCI,EHCI} depend on USB_SUPPORT.

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-usb@vger.kernel.org
---
 drivers/usb/Kconfig |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index cbd8f5f..76316a3 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -2,14 +2,6 @@
 # USB device configuration
 #
 
-menuconfig USB_SUPPORT
-	bool "USB support"
-	depends on HAS_IOMEM
-	default y
-	---help---
-	  This option adds core support for Universal Serial Bus (USB).
-	  You will also need drivers from the following menu to make use of it.
-
 # many non-PCI SOC chips embed OHCI
 config USB_ARCH_HAS_OHCI
 	boolean
@@ -63,6 +55,14 @@ config USB_ARCH_HAS_XHCI
 	boolean
 	default PCI
 
+menuconfig USB_SUPPORT
+	bool "USB support"
+	depends on HAS_IOMEM
+	default y
+	---help---
+	  This option adds core support for Universal Serial Bus (USB).
+	  You will also need drivers from the following menu to make use of it.
+
 if USB_SUPPORT
 
 config USB_COMMON
-- 
1.7.9.1

Re: [PATCH 1/1] usb: Kconfig fix display

[Anatolij Gustschin]

On Mon,  2 Apr 2012 13:13:50 +0200
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:

> Move HAS option before menuconfig so the USB option will show in the sub menu
> and not the drivers menu.
> Introduce in commit 53c6bc24fdc8db87109a5760579cbb060fa644cf usb: Don't make
> USB_ARCH_HAS_{XHCI,OHCI,EHCI} depend on USB_SUPPORT.
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: linux-usb@vger.kernel.org
> ---
>  drivers/usb/Kconfig |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)

Already fixed by

 http://marc.info/?l=linux-kernel&m=133245014825438&w=2

Re: [PATCH 1/1] usb: Kconfig fix display

[Sergei Shtylyov]

Hello.

On 04/02/2012 03:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:

> Move HAS option before menuconfig so the USB option will show in the sub menu
> and not the drivers menu.
> Introduce in commit 53c6bc24fdc8db87109a5760579cbb060fa644cf usb: Don't make
> USB_ARCH_HAS_{XHCI,OHCI,EHCI} depend on USB_SUPPORT.

> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD<plagnioj@jcrosoft.com>
> Cc: linux-usb@vger.kernel.org
> ---
>   drivers/usb/Kconfig |   16 ++++++++--------
>   1 files changed, 8 insertions(+), 8 deletions(-)

> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index cbd8f5f..76316a3 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -2,14 +2,6 @@
>   # USB device configuration
>   #
>
> -menuconfig USB_SUPPORT
> -	bool "USB support"
> -	depends on HAS_IOMEM
> -	default y
> -	---help---
> -	  This option adds core support for Universal Serial Bus (USB).
> -	  You will also need drivers from the following menu to make use of it.
> -
>   # many non-PCI SOC chips embed OHCI
>   config USB_ARCH_HAS_OHCI
>   	boolean
> @@ -63,6 +55,14 @@ config USB_ARCH_HAS_XHCI
>   	boolean
>   	default PCI
>
> +menuconfig USB_SUPPORT
> +	bool "USB support"
> +	depends on HAS_IOMEM
> +	default y
> +	---help---
> +	  This option adds core support for Universal Serial Bus (USB).
> +	  You will also need drivers from the following menu to make use of it.
> +
>   if USB_SUPPORT
>
>   config USB_COMMON

    Analogous patch has been already submitted by David Daney, author of the 
original breakage.

WBR, Sergei