public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* re: regulator: core: Use a struct to pass in regulator runtime configuration
@ 2012-04-11  9:06 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-04-11  9:06 UTC (permalink / raw)
  To: broonie; +Cc: linux-kernel

Hello Mark Brown,

This is a semi-automatic email about new static checker warnings.

The patch c172708d38a4: "regulator: core: Use a struct to pass in
regulator runtime configuration" from Apr 4, 2012, leads to the
following Smatch complaint:

drivers/regulator/core.c:2860 regulator_register()
	 warn: variable dereferenced before check 'config' (see line 2856)

drivers/regulator/core.c
  2855		struct regulator_dev *rdev;
  2856		struct device *dev = config->dev;
                                     ^^^^^^^^^^^
New dereference.

  2857		int ret, i;
  2858		const char *supply = NULL;
  2859	
  2860		if (regulator_desc == NULL || config == NULL)
                                              ^^^^^^^^^^^^^^
New check.

  2861			return ERR_PTR(-EINVAL);
  2862	

regards,
dan carpenter


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-04-11  9:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-11  9:06 regulator: core: Use a struct to pass in regulator runtime configuration Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox