* [PATCH] block: blk-ioc.c: local functions should not be exposed globally
@ 2012-04-12 22:36 H Hartley Sweeten
0 siblings, 0 replies; only message in thread
From: H Hartley Sweeten @ 2012-04-12 22:36 UTC (permalink / raw)
To: Linux Kernel; +Cc: axboe
The function ioc_set_icq_flags is only referenced in this file and
should be marked static to prevent it from being exposed globally.
This quiets the sparse warning:
warning: symbol 'ioc_set_icq_flags' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jens Axboe <axboe@kernel.dk>
---
diff --git a/block/blk-ioc.c b/block/blk-ioc.c
index fb95dd2..167bae0 100644
--- a/block/blk-ioc.c
+++ b/block/blk-ioc.c
@@ -382,7 +382,7 @@ struct io_cq *ioc_create_icq(struct request_queue *q, gfp_t gfp_mask)
return icq;
}
-void ioc_set_icq_flags(struct io_context *ioc, unsigned int flags)
+static void ioc_set_icq_flags(struct io_context *ioc, unsigned int flags)
{
struct io_cq *icq;
struct hlist_node *n;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-04-12 22:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-12 22:36 [PATCH] block: blk-ioc.c: local functions should not be exposed globally H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox