From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: hpa@zytor.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [PATCH] broken TASK_SIZE for ia32_aout
Date: Mon, 7 May 2012 00:32:34 +0100 [thread overview]
Message-ID: <20120506233234.GA22082@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120506.163243.1653904376439925642.davem@davemloft.net>
On Sun, May 06, 2012 at 04:32:43PM -0400, David Miller wrote:
> From: "H. Peter Anvin" <hpa@zytor.com>
> Date: Sun, 06 May 2012 11:48:15 -0700
>
> > I would argue Sparc is not correct here but I am not a Sparc expert.
>
> I can easily make sparc take on the x86 behavior if things like the
> input layer really need it.
BTW, in related area: take a look at syscall_get_arguments(). AFAICS,
it's rather odd -
#ifdef CONFIG_SPARC64
if (test_tsk_thread_flag(task, TIF_32BIT))
zero_extend = 1;
#endif
bit looks dubious. What happens when 32bit task makes a 64bit syscall?
Do we really want to drop upper 32 bits of all arguments in the copy we
are building?
next prev parent reply other threads:[~2012-05-06 23:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-06 16:20 [PATCH] broken TASK_SIZE for ia32_aout Al Viro
2012-05-06 17:16 ` Linus Torvalds
2012-05-06 17:37 ` H. Peter Anvin
2012-05-06 17:54 ` Al Viro
2012-05-06 17:56 ` Al Viro
2012-05-06 17:58 ` H. Peter Anvin
2012-05-06 18:46 ` Al Viro
2012-05-06 18:48 ` H. Peter Anvin
2012-05-06 19:58 ` Al Viro
2012-05-06 20:32 ` David Miller
2012-05-06 20:51 ` H. Peter Anvin
2012-05-06 23:40 ` David Miller
2012-05-06 23:48 ` H. Peter Anvin
2012-05-07 2:56 ` David Miller
2012-05-07 3:05 ` H. Peter Anvin
2012-05-06 23:32 ` Al Viro [this message]
2012-05-06 23:38 ` David Miller
2012-05-07 0:13 ` Al Viro
2012-05-07 0:24 ` Al Viro
2012-05-06 17:23 ` [tip:x86/urgent] x86, compat: Correct broken TASK_SIZE for ia32 a. out binaries tip-bot for Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506233234.GA22082@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox