The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: tip-bot for Al Viro <viro@ZenIV.linux.org.uk>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	viro@ZenIV.linux.org.uk, tglx@linutronix.de,
	viro@ZenIV.linux.org.uk
Subject: [tip:x86/urgent] x86, compat: Correct broken TASK_SIZE for ia32 a. out binaries
Date: Sun, 6 May 2012 10:23:04 -0700	[thread overview]
Message-ID: <tip-2be8e9ec677d6dfd4268b80e1ccd7d21777b86e3@git.kernel.org> (raw)
In-Reply-To: <20120506162000.GT6871@ZenIV.linux.org.uk>

Commit-ID:  2be8e9ec677d6dfd4268b80e1ccd7d21777b86e3
Gitweb:     http://git.kernel.org/tip/2be8e9ec677d6dfd4268b80e1ccd7d21777b86e3
Author:     Al Viro <viro@ZenIV.linux.org.uk>
AuthorDate: Sun, 6 May 2012 17:20:00 +0100
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Sun, 6 May 2012 09:53:15 -0700

x86, compat: Correct broken TASK_SIZE for ia32 a.out binaries

Setting TIF_IA32 in load_aout_binary() used to be enough; these days
TASK_SIZE is controlled by TIF_ADDR32 and that one doesn't get set
there.  Switch to use of set_personality_ia32()...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Link: http://lkml.kernel.org/r/20120506162000.GT6871@ZenIV.linux.org.uk
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/ia32/ia32_aout.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/ia32/ia32_aout.c b/arch/x86/ia32/ia32_aout.c
index d511d95..4c979cf 100644
--- a/arch/x86/ia32/ia32_aout.c
+++ b/arch/x86/ia32/ia32_aout.c
@@ -296,8 +296,7 @@ static int load_aout_binary(struct linux_binprm *bprm, struct pt_regs *regs)
 
 	/* OK, This is the point of no return */
 	set_personality(PER_LINUX);
-	set_thread_flag(TIF_IA32);
-	current->mm->context.ia32_compat = 1;
+	set_personality_ia32(false);
 
 	setup_new_exec(bprm);
 

      parent reply	other threads:[~2012-05-06 17:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 16:20 [PATCH] broken TASK_SIZE for ia32_aout Al Viro
2012-05-06 17:16 ` Linus Torvalds
2012-05-06 17:37   ` H. Peter Anvin
2012-05-06 17:54   ` Al Viro
2012-05-06 17:56     ` Al Viro
2012-05-06 17:58     ` H. Peter Anvin
2012-05-06 18:46       ` Al Viro
2012-05-06 18:48         ` H. Peter Anvin
2012-05-06 19:58           ` Al Viro
2012-05-06 20:32           ` David Miller
2012-05-06 20:51             ` H. Peter Anvin
2012-05-06 23:40               ` David Miller
2012-05-06 23:48                 ` H. Peter Anvin
2012-05-07  2:56                   ` David Miller
2012-05-07  3:05                     ` H. Peter Anvin
2012-05-06 23:32             ` Al Viro
2012-05-06 23:38               ` David Miller
2012-05-07  0:13                 ` Al Viro
2012-05-07  0:24     ` Al Viro
2012-05-06 17:23 ` tip-bot for Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-2be8e9ec677d6dfd4268b80e1ccd7d21777b86e3@git.kernel.org \
    --to=viro@zeniv.linux.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox