* [PATCH] IA32 Emulation: Fix build problem after commit ce7e5d2d1
@ 2012-05-07 0:40 Larry Finger
2012-05-07 1:17 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2012-05-07 0:40 UTC (permalink / raw)
To: viro, torvalds; +Cc: linux-kernel
Commit ce7e5d2d19bc ("x86: fix broken TASK_SIZE for ia32_aout") breaks kernel
builds when "CONFIG_IA32_AOUT=m" with
ERROR: "set_personality_ia32" [arch/x86/ia32/ia32_aout.ko] undefined!
make[1]: *** [__modpost] Error 1
The entry point needs to be exported.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: linux-2.6/arch/x86/kernel/process_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/process_64.c
+++ linux-2.6/arch/x86/kernel/process_64.c
@@ -423,6 +423,7 @@ void set_personality_ia32(bool x32)
current_thread_info()->status |= TS_COMPAT;
}
}
+EXPORT_SYMBOL_GPL(set_personality_ia32);
unsigned long get_wchan(struct task_struct *p)
{
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] IA32 Emulation: Fix build problem after commit ce7e5d2d1
2012-05-07 0:40 [PATCH] IA32 Emulation: Fix build problem after commit ce7e5d2d1 Larry Finger
@ 2012-05-07 1:17 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2012-05-07 1:17 UTC (permalink / raw)
To: Larry Finger; +Cc: torvalds, linux-kernel
On Sun, May 06, 2012 at 07:40:03PM -0500, Larry Finger wrote:
> Commit ce7e5d2d19bc ("x86: fix broken TASK_SIZE for ia32_aout") breaks kernel
> builds when "CONFIG_IA32_AOUT=m" with
>
> ERROR: "set_personality_ia32" [arch/x86/ia32/ia32_aout.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> The entry point needs to be exported.
ACK, with apologies - I don't normally use that sucker, obviously, so I'd just
flipped CONFIG_IA32_AOUT to y while testing. Missed that it was modular and
that no other binfmt using the same thing are modular, so it wasn't exported.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-07 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07 0:40 [PATCH] IA32 Emulation: Fix build problem after commit ce7e5d2d1 Larry Finger
2012-05-07 1:17 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox