public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Ping Cheng <pinglinux@gmail.com>
Cc: Peter Hutterer <peter.hutterer@who-t.net>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	chatty@enac.fr, chasedouglas@gmail.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Input: MT - Include win8 support
Date: Wed, 9 May 2012 21:39:02 +0200	[thread overview]
Message-ID: <20120509193902.GA12310@polaris.bitmath.org> (raw)
In-Reply-To: <CAF8JNhLv3iNgnhzrjEXSFRKUU4hAUKnz1dAadP1FnMxPtu90Sg@mail.gmail.com>

Hi Ping,

> > How about ABS_MT_TOOL_X/Y?
> 
> I am ok if we use any one of the suggested terms. The term is non
> technical per se. Readers will have to look into the spec to
> understand what exactly it means. But, I'd choose ABS_MT_CENTER_X/Y if
> we can only pick one from the suggested ones.
> 
> MT_TOOL_X/Y is unique. But, it introduces TOOL to the term. That makes
> me think about MT_TOOL_FINGER and MT_TOOL_PEN, which are irrelevant to
> this context.

On the contrary, tool as a base makes a lot of sense here. For the
single-pointer case, we have tool types and tool size already. If we
were to add a tool position, we would naturally think of
ABS_TOOL_X/Y. For the MT case, MT_TOOL_* are the tool types, and
ABS_MT_WIDTH_* is the tool size. It was chosen in analogy with
ABS_TOOL_WIDTH, although the TOOL part was dropped in favor of a
shorter name. In retrospect, ABS_MT_POSITION_X should have been named
ABS_MT_TOUCH_X and ABS_MT_WIDTH_MAJOR could have been named
ABS_MT_TOOL_MAJOR. This would more clearly have shown the events being
properties of two objects, tool and touch. With that in mind,
ABS_MT_TOOL_X is a natural choice.

Thanks,
Henrik

      reply	other threads:[~2012-05-09 19:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-05 15:08 [RFC] Input: MT - Include win8 support Henrik Rydberg
2012-05-05 20:07 ` Chase Douglas
2012-05-08 18:50   ` H. Peter Anvin
2012-05-08 19:37     ` Henrik Rydberg
2012-05-06 14:41 ` Benjamin Tissoires
2012-05-06 18:07   ` Henrik Rydberg
2012-05-06 18:28   ` Henrik Rydberg
2012-05-08  6:02     ` Peter Hutterer
2012-05-08 18:40       ` Henrik Rydberg
2012-05-08 23:52         ` Peter Hutterer
2012-05-09  5:35           ` Henrik Rydberg
2012-05-09 18:10             ` Ping Cheng
2012-05-09 19:39               ` Henrik Rydberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120509193902.GA12310@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@gmail.com \
    --cc=chasedouglas@gmail.com \
    --cc=chatty@enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox