* [patch] mfd: lm3533: silence a gcc warning
@ 2012-05-12 11:01 Dan Carpenter
2012-05-14 20:16 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-05-12 11:01 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, kernel-janitors
This is supposed to be umode_t. It causes a GCC warning:
drivers/mfd/lm3533-core.c:440:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/mfd/lm3533-core.c:440:2: warning: (near initialization for ‘lm3533_attribute_group.is_visible’) [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 75f4b7f..6f315d6 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -418,7 +418,7 @@ static struct attribute *lm3533_attributes[] = {
#define to_dev_attr(_attr) \
container_of(_attr, struct device_attribute, attr)
-static mode_t lm3533_attr_is_visible(struct kobject *kobj,
+static umode_t lm3533_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
struct device *dev = container_of(kobj, struct device, kobj);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mfd: lm3533: silence a gcc warning
2012-05-12 11:01 [patch] mfd: lm3533: silence a gcc warning Dan Carpenter
@ 2012-05-14 20:16 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-05-14 20:16 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
Hi Dan,
On Sat, May 12, 2012 at 02:01:04PM +0300, Dan Carpenter wrote:
> This is supposed to be umode_t. It causes a GCC warning:
> drivers/mfd/lm3533-core.c:440:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/mfd/lm3533-core.c:440:2: warning: (near initialization for ‘lm3533_attribute_group.is_visible’) [enabled by default]
>
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-14 20:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-12 11:01 [patch] mfd: lm3533: silence a gcc warning Dan Carpenter
2012-05-14 20:16 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox