* [PATCH] mfd: Add terminating entry for i2c_device_id table
@ 2012-05-21 15:33 Axel Lin
2012-05-22 10:11 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2012-05-21 15:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Graeme Gregory, Mark Brown, Liam Girdwood, Samuel Ortiz
The i2c_device_id table is supposed to be zero-terminated.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/palmas.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 00c0aba..5d896b3 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -472,6 +472,7 @@ static const struct i2c_device_id palmas_i2c_id[] = {
{ "twl6035", },
{ "twl6037", },
{ "tps65913", },
+ { /* end */ }
};
MODULE_DEVICE_TABLE(i2c, palmas_i2c_id);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: Add terminating entry for i2c_device_id table
2012-05-21 15:33 [PATCH] mfd: Add terminating entry for i2c_device_id table Axel Lin
@ 2012-05-22 10:11 ` Mark Brown
2012-05-22 20:08 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-05-22 10:11 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Graeme Gregory, Liam Girdwood, Samuel Ortiz
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
On Mon, May 21, 2012 at 11:33:22PM +0800, Axel Lin wrote:
> The i2c_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Samuel, Linus already pulled the regmap tree so this should probably go
via MFD as a bug fix? Might have to wait to after -rc1 to avoid you
having to rebase though...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Add terminating entry for i2c_device_id table
2012-05-22 10:11 ` Mark Brown
@ 2012-05-22 20:08 ` Samuel Ortiz
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-05-22 20:08 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Graeme Gregory, Liam Girdwood
Hi Mark,
On Tue, May 22, 2012 at 11:11:07AM +0100, Mark Brown wrote:
> On Mon, May 21, 2012 at 11:33:22PM +0800, Axel Lin wrote:
> > The i2c_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Samuel, Linus already pulled the regmap tree so this should probably go
> via MFD as a bug fix? Might have to wait to after -rc1 to avoid you
> having to rebase though...
Yes, I'm queueing this one for my first post merge window pull request.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-22 19:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 15:33 [PATCH] mfd: Add terminating entry for i2c_device_id table Axel Lin
2012-05-22 10:11 ` Mark Brown
2012-05-22 20:08 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox