The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2 1/3] perf script: Add general python handler to process non-tracepoint events
@ 2012-05-31  6:34 Feng Tang
  2012-05-31  6:34 ` [PATCH v2 2/3] perf script: Replace "struct thread" with "struct addr_location" as a parameter for "process_event()" Feng Tang
  2012-05-31  6:34 ` [PATCH v2 3/3] perf script/python: Pass thread/dso name and symbol info to event handler in python Feng Tang
  0 siblings, 2 replies; 6+ messages in thread
From: Feng Tang @ 2012-05-31  6:34 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, David Ahern, Peter Zijlstra,
	Ingo Molnar, Andi Kleen, Robert Richter, linux-kernel
  Cc: Feng Tang

This patch just follows Robert Richter's idea and the commit 37a058ea0
	"perf script: Add generic perl handler to process events"
to similarly add a python handler for general events other than tracepoints.

For non-tracepoint events, this patch will try to find a function named
"process_event" in the python script, and pass the event attribute,
perf_sample, raw_data in format of raw string. And the python script can
use "struct" module's unpack function to disasemble the needed info and process.

Signed-off-by: Feng Tang <feng.tang@intel.com>
---
 .../util/scripting-engines/trace-event-python.c    |   60 +++++++++++++++++++-
 1 files changed, 59 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
index acb9795..ab441a4 100644
--- a/tools/perf/util/scripting-engines/trace-event-python.c
+++ b/tools/perf/util/scripting-engines/trace-event-python.c
@@ -31,6 +31,7 @@
 #include "../event.h"
 #include "../thread.h"
 #include "../trace-event.h"
+#include "../evsel.h"
 
 PyMODINIT_FUNC initperf_trace_context(void);
 
@@ -209,7 +210,7 @@ static inline struct event_format *find_cache_event(int type)
 	return event;
 }
 
-static void python_process_event(union perf_event *pevent __unused,
+static void python_process_tracepoint(union perf_event *pevent __unused,
 				 struct perf_sample *sample,
 				 struct perf_evsel *evsel __unused,
 				 struct machine *machine __unused,
@@ -328,6 +329,63 @@ static void python_process_event(union perf_event *pevent __unused,
 	Py_DECREF(t);
 }
 
+static void python_process_general_event(union perf_event *pevent __unused,
+				 struct perf_sample *sample,
+				 struct perf_evsel *evsel,
+				 struct machine *machine __unused,
+				 struct thread *thread __unused)
+{
+	PyObject *handler, *retval, *t;
+	static char handler_name[64];
+	unsigned n = 0;
+	void *data = sample->raw_data;
+
+	t = PyTuple_New(MAX_FIELDS);
+	if (!t)
+		Py_FatalError("couldn't create Python tuple");
+
+	snprintf(handler_name, sizeof(handler_name), "%s", "process_event");
+
+	handler = PyDict_GetItemString(main_dict, handler_name);
+	if (handler && !PyCallable_Check(handler)) {
+		handler = NULL;
+		goto exit;
+	}
+
+	/* Pass 3 parameters: event_attr, perf_sample, raw data */
+	PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
+			(const char *)&evsel->attr, sizeof(evsel->attr)));
+	PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
+			(const char *)sample, sizeof(*sample)));
+	PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
+			data, sample->raw_size));
+
+	if (_PyTuple_Resize(&t, n) == -1)
+		Py_FatalError("error resizing Python tuple");
+
+	retval = PyObject_CallObject(handler, t);
+	if (retval == NULL)
+		handler_call_die(handler_name);
+exit:
+	Py_DECREF(t);
+}
+
+static void python_process_event(union perf_event *pevent,
+				 struct perf_sample *sample,
+				 struct perf_evsel *evsel,
+				 struct machine *machine,
+				 struct thread *thread)
+{
+	switch (evsel->attr.type) {
+	case PERF_TYPE_TRACEPOINT:
+		python_process_tracepoint(pevent, sample, evsel, machine, thread);
+		break;
+	/* Reserve for future process_hw/sw/raw APIs */
+	default:
+		python_process_general_event(pevent, sample, evsel, machine, thread);
+	}
+}
+
 static int run_start_sub(void)
 {
 	PyObject *handler, *retval;
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v3 0/3] perf script: Add general event support to event handler of python script
@ 2012-06-18  6:10 Feng Tang
  2012-06-18  6:10 ` [PATCH v3 2/3] perf script: Replace "struct thread" with "struct addr_location" as a parameter for "process_event()" Feng Tang
  0 siblings, 1 reply; 6+ messages in thread
From: Feng Tang @ 2012-06-18  6:10 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, David Ahern, Peter Zijlstra,
	Ingo Molnar, linux-kernel
  Cc: Robert Richter, Andi Kleen, Stephane Eranian, Feng Tang

Current python script can only handle trace point type of events, this
patch serie try to follow Robert Richter's idea in commit 37a058ea0
	"perf script: Add generic perl handler to process events"
to similarly add a python handler for general events other than
tracepoints.

Please help to revew, thanks.

- Feng


Change logs:
	Since v2:
	* Correct some __unused usage
	* Add a new parameter: event name to event handler 

	Since v1:
	* Use dictory as the paramter passwd from c to python 
	* Use "process_event" name to comply with perl

----------------
Feng Tang (3):
  perf script: Add general python handler to process non-tracepoint
    events
  perf script: Replace "struct thread" with "struct addr_location" as a
    parameter for "process_event()"
  perf script/python: Pass event/thread/dso name and symbol info to
    event handler in python

 tools/perf/builtin-script.c                        |    5 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   13 ++--
 .../util/scripting-engines/trace-event-python.c    |   81 +++++++++++++++++++-
 tools/perf/util/trace-event-scripting.c            |    2 +-
 tools/perf/util/trace-event.h                      |    4 +-
 5 files changed, 93 insertions(+), 12 deletions(-)


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-18  6:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-31  6:34 [PATCH v2 1/3] perf script: Add general python handler to process non-tracepoint events Feng Tang
2012-05-31  6:34 ` [PATCH v2 2/3] perf script: Replace "struct thread" with "struct addr_location" as a parameter for "process_event()" Feng Tang
2012-05-31 14:50   ` Arnaldo Carvalho de Melo
2012-06-01  1:45     ` [PATCH v3 " Feng Tang
2012-05-31  6:34 ` [PATCH v2 3/3] perf script/python: Pass thread/dso name and symbol info to event handler in python Feng Tang
  -- strict thread matches above, loose matches on Subject: below --
2012-06-18  6:10 [PATCH v3 0/3] perf script: Add general event support to event handler of python script Feng Tang
2012-06-18  6:10 ` [PATCH v3 2/3] perf script: Replace "struct thread" with "struct addr_location" as a parameter for "process_event()" Feng Tang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox