The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Liam Girdwood" <lrg@ti.com>, LKML <linux-kernel@vger.kernel.org>,
	"Axel Lin" <axel.lin@gmail.com>,
	"Heiko Stübner" <heiko@sntech.de>
Subject: [PATCH 0/3] regulator: gpio-regulator: Fixes for problems that turned up with 3.5-rc1
Date: Sun, 3 Jun 2012 21:29:45 +0200	[thread overview]
Message-ID: <201206032129.45414.heiko@sntech.de> (raw)

During the porting of my machine to 3.5-rc1 some glitches in the
gpio-regulator from different changes popped up.

This series fixes these.

While doing this, I noticed a possible uninitialized use of "selector" in
_regulator_do_set_voltage, where I'm not sure what the correct fix would be.

To summarize, before
	if (rdev->desc->ops->list_voltage)
		best_val = rdev->desc->ops->list_voltage(rdev, selector);
	else
		best_val = -1;

selector is set in the set_voltage callback or if the new map_voltage returns
a non-error value. If it returns an error value or the else clause is reached
selector is used uninitialized in the list_voltage and set_voltage_time_sel
call.

As written above, I'm not sure what the correct fix would be here.


Heiko Stuebner (3):
  regulator: gpio-regulator: do not pass drvdata pointer as reference
  regulator: gpio-regulator: Fix finding of smallest value
  regulator: gpio-regulator: populate selector from set_voltage

 drivers/regulator/gpio-regulator.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

-- 
1.7.2.3


             reply	other threads:[~2012-06-03 19:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-03 19:29 Heiko Stübner [this message]
2012-06-03 19:30 ` [PATCH 1/3] regulator: gpio-regulator: do not pass drvdata pointer as reference Heiko Stübner
2012-06-04  0:13   ` Axel Lin
2012-06-04  9:46   ` Mark Brown
2012-06-03 19:31 ` [PATCH 2/3] regulator: gpio-regulator: Fix finding of smallest value Heiko Stübner
2012-06-04  0:14   ` Axel Lin
2012-06-03 19:32 ` [PATCH 3/3] regulator: gpio-regulator: populate selector from set_voltage Heiko Stübner
2012-06-04  0:15   ` Axel Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206032129.45414.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox