From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>, LKML <linux-kernel@vger.kernel.org>,
Axel Lin <axel.lin@gmail.com>
Subject: [PATCH 2/3] regulator: gpio-regulator: Fix finding of smallest value
Date: Sun, 3 Jun 2012 21:31:09 +0200 [thread overview]
Message-ID: <201206032131.09429.heiko@sntech.de> (raw)
In-Reply-To: <201206032129.45414.heiko@sntech.de>
Commit 4dbd8f63f07a (regulator: gpio-regulator: Set the smallest
voltage/current in the specified range) forgot to set the newly
introduced best_val.
Therefore it stayed always at INT_MAX thus breaking the setting
of the voltage.
Included is also an init value for target, as warnings about
a possibly uninitialised target started appearing with this fix.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/regulator/gpio-regulator.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index ebe2b5c..2c38bea 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -104,13 +104,15 @@ static int gpio_regulator_set_value(struct regulator_dev *dev,
int min, int max)
{
struct gpio_regulator_data *data = rdev_get_drvdata(dev);
- int ptr, target, state, best_val = INT_MAX;
+ int ptr, target = 0, state, best_val = INT_MAX;
for (ptr = 0; ptr < data->nr_states; ptr++)
if (data->states[ptr].value < best_val &&
data->states[ptr].value >= min &&
- data->states[ptr].value <= max)
+ data->states[ptr].value <= max) {
target = data->states[ptr].gpios;
+ best_val = data->states[ptr].value;
+ }
if (best_val == INT_MAX)
return -EINVAL;
--
1.7.2.3
next prev parent reply other threads:[~2012-06-03 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 19:29 [PATCH 0/3] regulator: gpio-regulator: Fixes for problems that turned up with 3.5-rc1 Heiko Stübner
2012-06-03 19:30 ` [PATCH 1/3] regulator: gpio-regulator: do not pass drvdata pointer as reference Heiko Stübner
2012-06-04 0:13 ` Axel Lin
2012-06-04 9:46 ` Mark Brown
2012-06-03 19:31 ` Heiko Stübner [this message]
2012-06-04 0:14 ` [PATCH 2/3] regulator: gpio-regulator: Fix finding of smallest value Axel Lin
2012-06-03 19:32 ` [PATCH 3/3] regulator: gpio-regulator: populate selector from set_voltage Heiko Stübner
2012-06-04 0:15 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206032131.09429.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox